From: "H. Peter Anvin" <hpa@zytor.com>
To: mingo@kernel.org, hpa@zytor.com, alan@linux.intel.com,
linux-kernel@vger.kernel.org, tglx@linutronix.de,
arne@fitzenreiter.de
Cc: linux-tip-commits@vger.kernel.org
Subject: Re: [tip:x86/urgent] x86: Fix boot on Twinhead H12Y
Date: Thu, 17 May 2012 11:29:23 -0700 [thread overview]
Message-ID: <4FB54383.5020703@zytor.com> (raw)
In-Reply-To: <tip-80b3e557371205566a71e569fbfcce5b11f92dbe@git.kernel.org>
On 05/17/2012 11:22 AM, tip-bot for Alan Cox wrote:
> Commit-ID: 80b3e557371205566a71e569fbfcce5b11f92dbe
> Gitweb: http://git.kernel.org/tip/80b3e557371205566a71e569fbfcce5b11f92dbe
> Author: Alan Cox <alan@linux.intel.com>
> AuthorDate: Tue, 15 May 2012 18:44:15 +0100
> Committer: Ingo Molnar <mingo@kernel.org>
> CommitDate: Thu, 17 May 2012 20:04:00 +0200
>
> x86: Fix boot on Twinhead H12Y
>
> Despite lots of investigation into why this is needed we don't
> know or have an elegant cure. The only answer found on this
> laptop is to mark a problem region as used so that Linux doesn't
> put anything there.
>
> Currently all the users add reserve= command lines and anyone
> not knowing this needs to find the magic page that documents it.
> Automate it instead.
>
> Signed-off-by: Alan Cox <alan@linux.intel.com>
> Tested-and-bugfixed-by: Arne Fitzenreiter <arne@fitzenreiter.de>
> Resolves-bug: https://bugzilla.kernel.org/show_bug.cgi?id=10231
> Link: http://lkml.kernel.org/r/20120515174347.5109.94551.stgit@bluebook
> Signed-off-by: Ingo Molnar <mingo@kernel.org>
> ---
> arch/x86/pci/fixup.c | 17 +++++++++++++++++
> 1 files changed, 17 insertions(+), 0 deletions(-)
>
> diff --git a/arch/x86/pci/fixup.c b/arch/x86/pci/fixup.c
> index d0e6e40..5dd467b 100644
> --- a/arch/x86/pci/fixup.c
> +++ b/arch/x86/pci/fixup.c
> @@ -519,3 +519,20 @@ static void sb600_disable_hpet_bar(struct pci_dev *dev)
> }
> }
> DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_ATI, 0x4385, sb600_disable_hpet_bar);
> +
> +/*
> + * Twinhead H12Y needs us to block out a region otherwise we map devices
> + * there and any access kills the box.
> + *
> + * See: https://bugzilla.kernel.org/show_bug.cgi?id=10231
> + *
> + * Match off the LPC and svid/sdid (older kernels lose the bridge subvendor)
> + */
> +static void __devinit twinhead_reserve_killing_zone(struct pci_dev *dev)
> +{
> + if (dev->subsystem_vendor == 0x14FF && dev->subsystem_device == 0xA003) {
> + pr_info("Reserving memory on Twinhead H12Y\n");
> + request_mem_region(0xFFB00000, 0x100000, "twinhead");
> + }
> +}
> +DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, 0x27B9, twinhead_reserve_killing_zone);
It seems to me that a DMI match might be more appropriate, since it
pretty much sounds like the BIOS fails to reserve a region it is using?
-hpa
next prev parent reply other threads:[~2012-05-17 18:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-15 17:44 [PATCH] x86: Fix boot on Twinhead H12Y Alan Cox
2012-05-15 16:52 ` Joe Perches
2012-05-15 17:09 ` Alan Cox
2012-05-17 18:22 ` [tip:x86/urgent] " tip-bot for Alan Cox
2012-05-17 18:29 ` H. Peter Anvin [this message]
2012-05-17 19:56 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FB54383.5020703@zytor.com \
--to=hpa@zytor.com \
--cc=alan@linux.intel.com \
--cc=arne@fitzenreiter.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox