From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967844Ab2EQXMI (ORCPT ); Thu, 17 May 2012 19:12:08 -0400 Received: from terminus.zytor.com ([198.137.202.10]:38384 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965253Ab2EQXMF (ORCPT ); Thu, 17 May 2012 19:12:05 -0400 Message-ID: <4FB585B8.2010607@zytor.com> Date: Thu, 17 May 2012 16:11:52 -0700 From: "H. Peter Anvin" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 MIME-Version: 1.0 To: David Daney CC: "H.J. Lu" , Ralf Baechle , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, torvalds@linux-foundation.org, mingo@kernel.org, tglx@linutronix.de Subject: Re: [RFC PATCH 00/10] Use __kernel_[u]long_t for x32 user space compatibility References: <1337292816-10839-1-git-send-email-hjl.tools@gmail.com> <4FB584C0.6080807@gmail.com> In-Reply-To: <4FB584C0.6080807@gmail.com> X-Enigmail-Version: 1.4 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/17/2012 04:07 PM, David Daney wrote: > > Has anybody checked how this affects MIPS n32 userspace? > > I think it totally breaks it. > Do you have any basis whatsoever for that statement? This should have zero effect on any non-x32 platforms. > In addition, 109a1f32 (sysinfo: Use explicit types in ) > is probably bad. I think it may need to be reverted, or somebody should > fix all the __kernel_{,u}long_t definitions for the ABI that may have > been broken by the change. You realize __kernel_[u]long_t didn't even exist until the 3.4 kernel, right? -hpa -- H. Peter Anvin, Intel Open Source Technology Center I work for Intel. I don't speak on their behalf.