From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Evgeniy Dushistov <dushistov@mail.ru>
Subject: Re: [PATCH] Increase file size limit on FreeBSD UFS flavours
Date: Fri, 18 May 2012 06:42:34 +0200 [thread overview]
Message-ID: <4FB5D33A.1040400@gmail.com> (raw)
In-Reply-To: <20120517161052.d37cf8ae.akpm@linux-foundation.org>
[-- Attachment #1: Type: text/plain, Size: 1846 bytes --]
On 18.05.2012 01:10, Andrew Morton wrote:
> On Sun, 13 May 2012 15:50:40 +0200
> Vladimir '__-coder/phcoder' Serbinenko <phcoder@gmail.com> wrote:
>
>> Increase the file size limit on FreeBSD UFS flavours.
>>
>> Signed-off-by: Vladimir Serbinenko <phcoder@gmail.com>
>>
>> diff --git a/fs/ufs/super.c b/fs/ufs/super.c
>> index ac8e279..7e80a68 100644
>> --- a/fs/ufs/super.c
>> +++ b/fs/ufs/super.c
>> @@ -768,6 +768,7 @@ static int ufs_fill_super(struct super_block *sb, void *data, int silent)
>> uspi->s_fshift = 9;
>> uspi->s_sbsize = super_block_size = 1536;
>> uspi->s_sbbase = 0;
>> + sb->s_maxbytes = MAX_LFS_FILESIZE;
>> flags |= UFS_DE_44BSD | UFS_UID_44BSD | UFS_ST_44BSD | UFS_CG_44BSD;
>> break;
>> case UFS_MOUNT_UFSTYPE_UFS2:
>> @@ -778,6 +779,7 @@ static int ufs_fill_super(struct super_block *sb, void *data, int silent)
>> uspi->s_fshift = 9;
>> uspi->s_sbsize = super_block_size = 1536;
>> uspi->s_sbbase = 0;
>> + sb->s_maxbytes = MAX_LFS_FILESIZE;
>> flags |= UFS_TYPE_UFS2 | UFS_DE_44BSD | UFS_UID_44BSD | UFS_ST_44BSD | UFS_CG_44BSD;
>> break;
>>
>
> But MAX_NON_LFS exists for a reason. Before this change, the Linux UFS
> implementation had never had to deal with >4G files (I assume).
>
> Are you telling us that the fs has been thoroughly audited and tested
> with large files and that it all worked OK with no other changes?
>
The comment indicated that this was simply because the author wasn't
sure as to which UFS flavours actually supported big files. I've tested
it only by creating big file, unmounting the filesystem and then
comparing the read against another UFS implementation (the one in GRUB)
and obtaining perfect match. I haven't done any thorough audit.
--
Regards
Vladimir 'φ-coder/phcoder' Serbinenko
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 294 bytes --]
prev parent reply other threads:[~2012-05-18 4:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-13 13:50 [PATCH] Increase file size limit on FreeBSD UFS flavours Vladimir 'φ-coder/phcoder' Serbinenko
2012-05-17 23:10 ` Andrew Morton
2012-05-18 4:42 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FB5D33A.1040400@gmail.com \
--to=phcoder@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dushistov@mail.ru \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).