From: Ian Abbott <abbotti@mev.co.uk>
To: H Hartley Sweeten <hartleys@visionengravers.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
Ian Abbott <ian.abbott@mev.co.uk>,
"fmhess@users.sourceforge.net" <fmhess@users.sourceforge.net>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] staging: comedi: cleanup all the comedi_driver 'detach' functions
Date: Fri, 18 May 2012 11:23:08 +0100 [thread overview]
Message-ID: <4FB6230C.2080604@mev.co.uk> (raw)
In-Reply-To: <201205171711.14968.hartleys@visionengravers.com>
On 2012-05-18 01:11, H Hartley Sweeten wrote:
> 2. Remove all the printk noise in the detach functions
>
> All of the printk output is really just noise. The user did a rmmod to
> unload the driver, we really don't need to tell them about it.
I disagree. It's not that unusual for drivers to report device removal.
(It's not necessarily due to an rmmod either, not that that really
matters.)
> Also, some of the messages are output using:
>
> dev_dbg(dev->hw_dev, ...
> or
> dev_info(dev->hw_dev, ...
>
> Unfortunately the hw_dev value is only used by drivers that are doing
> DMA. For most drivers this variable is going to be NULL so the output
> is not going to work as expected.
Agreed, those are bugs introduced by someone else's "cleanup"!
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
next prev parent reply other threads:[~2012-05-18 10:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-18 0:11 [PATCH] staging: comedi: cleanup all the comedi_driver 'detach' functions H Hartley Sweeten
2012-05-18 10:23 ` Ian Abbott [this message]
2012-05-18 16:56 ` H Hartley Sweeten
2012-05-18 17:48 ` Ian Abbott
2012-05-18 17:52 ` H Hartley Sweeten
2012-05-19 6:48 ` Ian Abbott
2012-05-19 0:32 ` Greg KH
2012-05-19 6:42 ` Ian Abbott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FB6230C.2080604@mev.co.uk \
--to=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=fmhess@users.sourceforge.net \
--cc=gregkh@linuxfoundation.org \
--cc=hartleys@visionengravers.com \
--cc=ian.abbott@mev.co.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox