public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Chris Metcalf <cmetcalf@tilera.com>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tile: set KBUILD_DEFCONFIG to point at a real config file
Date: Fri, 18 May 2012 21:08:31 -0400	[thread overview]
Message-ID: <4FB6F28F.3090404@tilera.com> (raw)
In-Reply-To: <1337381165-7376-1-git-send-email-paul.gortmaker@windriver.com>

On 5/18/2012 6:46 PM, Paul Gortmaker wrote:
> To fix this:
>
> ~/git/linux-head$ make defconfig
> *** Default configuration is based on 'tile_defconfig'
> ***
> *** Can't find default configuration "arch/tile/configs/tile_defconfig"!
> ***
> make[1]: *** [defconfig] Error 1
> make: *** [defconfig] Error 2
>
> There is no need to use $ARCH in the tile/Makefile, since if we are
> in there, we know ARCH must be tile.  Use the GX as the defconfig,
> as that is what is used in linux-next.

No, the odd thing about arch/tile is that you must build it either as
ARCH=tilepro or ARCH=tilegx.  There is no ARCH=tile.  So the $ARCH piece is
actually correct.

> Cc: Chris Metcalf <cmetcalf@tilera.com>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
>
> diff --git a/arch/tile/Makefile b/arch/tile/Makefile
> index 5015144..89f2310 100644
> --- a/arch/tile/Makefile
> +++ b/arch/tile/Makefile
> @@ -34,7 +34,7 @@ LIBGCC_PATH     := \
>    $(shell $(CC) $(KBUILD_CFLAGS) $(KCFLAGS) -print-libgcc-file-name)
>  
>  # Provide the path to use for "make defconfig".
> -KBUILD_DEFCONFIG := $(ARCH)_defconfig
> +KBUILD_DEFCONFIG := tilegx_defconfig
>  
>  # Used as a file extension when useful, e.g. head_$(BITS).o
>  # Not needed for (e.g.) "$(CC) -m32" since the compiler automatically

-- 
Chris Metcalf, Tilera Corp.
http://www.tilera.com


  reply	other threads:[~2012-05-19  1:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-18 22:46 [PATCH] tile: set KBUILD_DEFCONFIG to point at a real config file Paul Gortmaker
2012-05-19  1:08 ` Chris Metcalf [this message]
2012-05-19  3:18   ` Paul Gortmaker
2012-05-19 14:04     ` Chris Metcalf
2012-05-20 16:20       ` Paul Gortmaker
2012-05-20 19:15     ` [PATCH] tile: default to tilegx_defconfig for ARCH=tile Chris Metcalf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FB6F28F.3090404@tilera.com \
    --to=cmetcalf@tilera.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paul.gortmaker@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox