From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754604Ab2ESRTM (ORCPT ); Sat, 19 May 2012 13:19:12 -0400 Received: from hqemgate03.nvidia.com ([216.228.121.140]:19747 "EHLO hqemgate03.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751298Ab2ESRTG (ORCPT ); Sat, 19 May 2012 13:19:06 -0400 X-PGP-Universal: processed; by hqnvupgp06.nvidia.com on Sat, 19 May 2012 10:19:05 -0700 Message-ID: <4FB7D4D8.2050501@nvidia.com> Date: Sat, 19 May 2012 22:44:00 +0530 From: Laxman Dewangan User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20101208 Thunderbird/3.1.7 MIME-Version: 1.0 To: Mark Brown CC: "lrg@ti.com" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] regulator: core: use correct device for device supply lookup References: <1337436846-30025-1-git-send-email-ldewangan@nvidia.com> <20120519164134.GT4039@opensource.wolfsonmicro.com> In-Reply-To: <20120519164134.GT4039@opensource.wolfsonmicro.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Saturday 19 May 2012 10:11 PM, Mark Brown wrote: > * PGP Signed by an unknown key > > On Sat, May 19, 2012 at 07:44:06PM +0530, Laxman Dewangan wrote: >> When registering the regulator driver, use the rdev->dev for >> getting the regulator device of given supply instead of parent >> device. > You're providing no motivation for this and it's difficult to see how it > improves things. The class device is dynamically numbered so it's not > suitable for specifying supplies on a non-DT system and for a DT system > it's not obvious to me that we would want to involve the class device in > anything, it requires an additional layer of indirection but that's > about it. If I dont do this then it will not enter in the following case for getting the regulator_dev of supply regulator because dev->of_node is null, the tps65910-regulator driver have not set the pdev->dev.ofnode. static struct regulator_dev *regulator_dev_lookup(struct device *dev, const char *supply, int *ret) { /* first do a dt based lookup */ if (dev && dev->of_node) { :::::::::::::::: /* Get the regulator device */ } :::::::::::::::::: }