From: Vipul Pandya <vipul@chelsio.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Roland Dreier <roland@kernel.org>,
linux-rdma@vger.kernel.org, linux-next@vger.kernel.org,
linux-kernel@vger.kernel.org,
Steve Wise <swise@opengridcomputing.com>
Subject: Re: linux-next: build failure after merge of the infiniband tree
Date: Mon, 21 May 2012 19:34:52 +0530 [thread overview]
Message-ID: <4FBA4B84.9030302@chelsio.com> (raw)
In-Reply-To: <20120521120512.15f1e9dfc961b05dfee72f79@canb.auug.org.au>
On 21-05-2012 07:35, Stephen Rothwell wrote:
> Hi all,
>
> After merging the infiniband tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> drivers/infiniband/hw/cxgb4/device.c: In function 'qp_release':
> drivers/infiniband/hw/cxgb4/device.c:124:2: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration]
> drivers/infiniband/hw/cxgb4/device.c: In function 'qp_open':
> drivers/infiniband/hw/cxgb4/device.c:148:2: error: implicit declaration of function 'vmalloc' [-Werror=implicit-function-declaration]
> drivers/infiniband/hw/cxgb4/device.c:148:11: warning: assignment makes pointer from integer without a cast [enabled by default]
>
> Caused by commit d716a2a014ad ("RDMA/cxgb4: Use vmalloc() for debugfs QP
> dump"). See Rule 1 in Documentation/SubmitChecklist.
>
> I have used the infiniband tree from next-20120518 for today.
>
Hi Stephen,
Below patch should resolve this issue.
>From 433d2002d3ba2119146fdec6e0a97b67834df960 Mon Sep 17 00:00:00 2001
From: Vipul Pandya <vipul@chelsio.com>
Date: Mon, 21 May 2012 17:31:13 +0530
Subject: [PATCH] RDMA/cxgb4: Include vmalloc.h for vmalloc and vfree
Signed-off-by: Vipul Pandya <vipul@chelsio.com>
---
drivers/infiniband/hw/cxgb4/device.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/infiniband/hw/cxgb4/device.c
b/drivers/infiniband/hw/cxgb4/device.c
index c8fd1d8..cb4ecd7 100644
--- a/drivers/infiniband/hw/cxgb4/device.c
+++ b/drivers/infiniband/hw/cxgb4/device.c
@@ -32,6 +32,7 @@
#include <linux/module.h>
#include <linux/moduleparam.h>
#include <linux/debugfs.h>
+#include <linux/vmalloc.h>
#include <rdma/ib_verbs.h>
--
next prev parent reply other threads:[~2012-05-21 14:12 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-21 2:05 linux-next: build failure after merge of the infiniband tree Stephen Rothwell
2012-05-21 14:04 ` Vipul Pandya [this message]
2012-05-21 16:03 ` Roland Dreier
-- strict thread matches above, loose matches on Subject: below --
2015-02-18 2:32 Stephen Rothwell
2015-02-18 3:01 ` Roland Dreier
2014-12-16 1:47 Stephen Rothwell
2014-12-16 1:56 ` Roland Dreier
2014-12-16 2:22 ` Roland Dreier
2014-12-16 10:57 ` Or Gerlitz
2012-12-19 22:44 Stephen Rothwell
2012-12-20 0:22 ` Roland Dreier
2012-12-20 9:58 ` Vipul Pandya
2012-08-16 1:44 Stephen Rothwell
2012-08-16 4:07 ` Roland Dreier
2012-08-16 6:59 ` Stephen Rothwell
2012-07-06 2:35 Stephen Rothwell
2012-07-06 3:58 ` Roland Dreier
2012-07-06 6:31 ` Hefty, Sean
2011-10-11 3:49 Stephen Rothwell
2010-07-09 1:04 Stephen Rothwell
2010-07-09 3:05 ` Ben Hutchings
2010-07-09 3:46 ` Roland Dreier
2010-07-09 6:16 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FBA4B84.9030302@chelsio.com \
--to=vipul@chelsio.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=roland@kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=swise@opengridcomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox