public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Justin P. Mattock" <justinmattock@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH NEXT]staging: "rts_pstor" Fix typos.
Date: Mon, 21 May 2012 07:54:47 -0700	[thread overview]
Message-ID: <4FBA5737.3010209@gmail.com> (raw)
In-Reply-To: <20120521143530.GC4637@mwanda>

On 05/21/2012 07:35 AM, Dan Carpenter wrote:
> On Mon, May 21, 2012 at 07:19:15AM -0700, Justin P. Mattock wrote:
>> From: "Justin P. Mattock"<justinmattock@gmail.com>
>>
>>   Signed-off-by: Justin P. Mattock<justinmattock@gmail.com>
>    ^
> Your scripts are adding an extra space here.i

after git format-patch my signature is in the subject line. pressing 
enter a few times moves it down. is there a git command for properly 
aligning this?
>
>>
>> ---
>>
>> The below patch fixes some typos found while reading through rts_pstor.
>
> This could go in the patch description if you wanted.
>
>>
>>   drivers/staging/rts_pstor/ms.c |    2 +-
>>   drivers/staging/rts_pstor/sd.c |    2 +-
>>   2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/staging/rts_pstor/ms.c b/drivers/staging/rts_pstor/ms.c
>> index 0bf6d95..3b75739 100644
>> --- a/drivers/staging/rts_pstor/ms.c
>> +++ b/drivers/staging/rts_pstor/ms.c
>> @@ -2488,7 +2488,7 @@ int reset_ms_card(struct rtsx_chip *chip)
>>
>>   	if (!CHK_MSPRO(ms_card)) {
>>   		/* Build table for the last segment,
>> -		 * to check if L2P talbe block exist,erasing it
>> +		 * to check if L2P table block exist,erasing it
>
> I still have no idea what this comment means but "exist" =>  "exists"
> and it needs a space after the comma.

most of them I have no idea as well.. anyway resending with the fixes..
>
>>   		*/
>>   		retval = ms_build_l2p_tbl(chip, ms_card->total_block / 512 - 1);
>>   		if (retval != STATUS_SUCCESS) {
>
> regards,
> dan carpenter
>

Justin P. Mattock

  reply	other threads:[~2012-05-21 14:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-21 14:19 [PATCH NEXT]staging: "rts_pstor" Fix typos Justin P. Mattock
2012-05-21 14:35 ` Dan Carpenter
2012-05-21 14:54   ` Justin P. Mattock [this message]
2012-05-21 15:26     ` Dan Carpenter
2012-05-21 15:30       ` Justin P. Mattock

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FBA5737.3010209@gmail.com \
    --to=justinmattock@gmail.com \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox