From: "Justin P. Mattock" <justinmattock@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH NEXT]staging: "rts_pstor" Fix typos.
Date: Mon, 21 May 2012 08:30:10 -0700 [thread overview]
Message-ID: <4FBA5F82.7080003@gmail.com> (raw)
In-Reply-To: <20120521152626.GE4629@mwanda>
On 05/21/2012 08:26 AM, Dan Carpenter wrote:
> On Mon, May 21, 2012 at 07:54:47AM -0700, Justin P. Mattock wrote:
>> On 05/21/2012 07:35 AM, Dan Carpenter wrote:
>>> On Mon, May 21, 2012 at 07:19:15AM -0700, Justin P. Mattock wrote:
>>>> From: "Justin P. Mattock"<justinmattock@gmail.com>
>>>>
>>>> Signed-off-by: Justin P. Mattock<justinmattock@gmail.com>
>>> ^
>>> Your scripts are adding an extra space here.i
>>
>> after git format-patch my signature is in the subject line. pressing
>> enter a few times moves it down. is there a git command for properly
>> aligning this?
>
> The first line is the subject and then you need to leave the next
> line of the commit blank.
>
> regards,
> dan carpenter
>
>
ahh.. I know what im doing wrong, im not doing all of this while doing
git commit -s -a. I add the subject etc.. after committing and
formatting the patch.
Justin P. Mattock
prev parent reply other threads:[~2012-05-21 15:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-21 14:19 [PATCH NEXT]staging: "rts_pstor" Fix typos Justin P. Mattock
2012-05-21 14:35 ` Dan Carpenter
2012-05-21 14:54 ` Justin P. Mattock
2012-05-21 15:26 ` Dan Carpenter
2012-05-21 15:30 ` Justin P. Mattock [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FBA5F82.7080003@gmail.com \
--to=justinmattock@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox