linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alex Shi <alex.shi@intel.com>
To: Alex Shi <alex.shi@intel.com>
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
	seto.hidetoshi@jp.fujitsu.com, borislav.petkov@amd.com,
	tony.luck@intel.com, luto@mit.edu, jbeulich@suse.com,
	rostedt@goodmis.org, ak@linux.intel.com,
	akpm@linux-foundation.org, eric.dumazet@gmail.com,
	akinobu.mita@gmail.com, linux-kernel@vger.kernel.org,
	Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH] x86/tlb: replace INVALIDATE_TLB_VECTOR by CALL_FUNCTION_VECTOR
Date: Tue, 22 May 2012 08:16:45 +0800	[thread overview]
Message-ID: <4FBADAED.1010807@intel.com> (raw)
In-Reply-To: <4FB7004B.4010806@intel.com>

On 05/19/2012 10:07 AM, Alex Shi wrote:

> On 05/18/2012 11:12 PM, Alex Shi wrote:
> 
>> There are only 32 INVALIDATE_TLB_VECTOR now in kernel.
>> but modern x86 sever has more cpu number. That causes lock
>> contention in TLB flushing.
>>
>> Now, useing generic smp call function to replace it.
>> In the NHM EX machine 4P * 8cores * HT = 64 CPUs, hackbench pthread
>> has 3% performance increase.
>> And no clear performance changes on NHM EP(16CPUs), WSM EP(23CPU)
>> and SNB EP(32CPU) machines.
>>
>> This patch is base on my tlb flush range support patchset.
>>
>> Signed-off-by: Alex Shi <alex.shi@intel.com>
> 
> 
> 
> refresh this patch will more clean up, and cc to PeterZ.
> Actually, I tried to keep flush_tlb_info into dedicated cache line, but did find clear help.


Correct: I did _not_ find clear help for dedicated cache line for
flush_tlb_info.

> 
> Comments are appreciated!
> 


Any comments for this patch?

  reply	other threads:[~2012-05-22  0:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-18 15:12 [PATCH] x86/tlb: replace INVALIDATE_TLB_VECTOR by CALL_FUNCTION_VECTOR Alex Shi
2012-05-19  2:07 ` Alex Shi
2012-05-22  0:16   ` Alex Shi [this message]
2012-05-25 14:23   ` Peter Zijlstra
2012-05-29  7:42     ` Alex Shi
2012-05-31  8:40       ` Alex Shi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FBADAED.1010807@intel.com \
    --to=alex.shi@intel.com \
    --cc=ak@linux.intel.com \
    --cc=akinobu.mita@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=borislav.petkov@amd.com \
    --cc=eric.dumazet@gmail.com \
    --cc=hpa@zytor.com \
    --cc=jbeulich@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@mit.edu \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=seto.hidetoshi@jp.fujitsu.com \
    --cc=tglx@linutronix.de \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).