From: David Ahern <dsahern@gmail.com>
To: Tim Chen <tim.c.chen@linux.intel.com>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
linux-kernel <linux-kernel@vger.kernel.org>,
ak@linux.intel.com, Stephane Eranian <eranian@google.com>
Subject: Re: Does perf inject preserve call chain data?
Date: Tue, 22 May 2012 15:58:40 -0600 [thread overview]
Message-ID: <4FBC0C10.8010801@gmail.com> (raw)
In-Reply-To: <1337712585.3796.186.camel@schen9-DESK>
On 5/22/12 12:49 PM, Tim Chen wrote:
> Arnaldo,
>
> Wonder if perf inject munged the call chain data from perf record?
>
> When I do
> perf record -a -g -o - sleep 5 |perf inject -v -b | perf report -g -i -
> I get a complain from perf report
>
> Warning:
> Selected -g but no callchain data. Did you call 'perf record' without -g?
>
I believe the root cause is that the event list is not written to the
pipe. Using Arnaldo's git repo as of today (has fixes from Stephane)
this hack shows the info is there and can be processed.
diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index d58e414..60f3f17 100644
--- a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -256,7 +257,7 @@ static int perf_report__setup_sample_type(struct
perf_report *rep)
"'perf record' without -g?\n");
return -EINVAL;
}
- if (symbol_conf.use_callchain) {
+ if (!self->fd_pipe && symbol_conf.use_callchain) {
ui__warning("Selected -g but no callchain data. Did "
"you call 'perf record' without -g?\n");
return -1;
A proper solution is needed.
David
next prev parent reply other threads:[~2012-05-22 21:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-22 18:49 Does perf inject preserve call chain data? Tim Chen
2012-05-22 21:58 ` David Ahern [this message]
2012-06-08 14:38 ` Arnaldo Carvalho de Melo
2012-06-08 16:44 ` Tim Chen
2012-06-08 17:13 ` David Ahern
2012-06-08 17:17 ` Tim Chen
2012-06-08 19:52 ` Andi Kleen
2012-06-09 16:05 ` Arnaldo Carvalho de Melo
2012-06-11 18:43 ` Andi Kleen
2012-06-11 19:11 ` David Ahern
2012-06-11 21:59 ` Arnaldo Carvalho de Melo
2012-06-11 22:11 ` Andi Kleen
2012-06-12 0:02 ` Arnaldo Carvalho de Melo
2012-06-11 18:23 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FBC0C10.8010801@gmail.com \
--to=dsahern@gmail.com \
--cc=acme@ghostprotocols.net \
--cc=ak@linux.intel.com \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tim.c.chen@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox