From: Ian Abbott <abbotti@mev.co.uk>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: H Hartley Sweeten <hartleys@visionengravers.com>,
Ian Abbott <ian.abbott@mev.co.uk>,
Linux Kernel <linux-kernel@vger.kernel.org>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"fmhess@users.sourceforge.net" <fmhess@users.sourceforge.net>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] staging: comedi: remove this_board macro in the s526 driver
Date: Thu, 24 May 2012 09:53:41 +0100 [thread overview]
Message-ID: <4FBDF715.4050808@mev.co.uk> (raw)
In-Reply-To: <20120523190715.GP4629@mwanda>
On 2012-05-23 20:07, Dan Carpenter wrote:
> On Wed, May 23, 2012 at 11:28:32AM -0500, H Hartley Sweeten wrote:
>> This would allow comedi_recognize() to walk the boardinfo
>> to find the match without all the ugly casts.
>
> That function wouldn't be so bad if we just removed all the consts.
> There is no point because we drop all of them anyway when we return
> the struct.
Well maybe some of the consts. We could use const char **name_ptr
instead of const char *const *name_ptr. *name_ptr is never modified,
but as name_ptr is just a local variable, the compiler can figure that
out for itself without the extra const.
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
next prev parent reply other threads:[~2012-05-24 8:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-23 1:20 [PATCH] staging: comedi: remove this_board macro in the s526 driver H Hartley Sweeten
2012-05-23 5:48 ` Dan Carpenter
2012-05-23 9:18 ` Ian Abbott
2012-05-23 16:28 ` H Hartley Sweeten
2012-05-23 16:48 ` Ian Abbott
2012-05-23 16:53 ` H Hartley Sweeten
2012-05-23 19:07 ` Dan Carpenter
2012-05-24 8:53 ` Ian Abbott [this message]
2012-05-23 16:06 ` H Hartley Sweeten
2012-05-23 18:51 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FBDF715.4050808@mev.co.uk \
--to=abbotti@mev.co.uk \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=fmhess@users.sourceforge.net \
--cc=gregkh@linuxfoundation.org \
--cc=hartleys@visionengravers.com \
--cc=ian.abbott@mev.co.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox