From: "H. Peter Anvin" <hpa@zytor.com>
To: Joe Perches <joe@perches.com>
Cc: T Makphaibulchoke <tmac@hp.com>,
lethal@linux-sh.org, tglx@linutronix.de, mingo@redhat.com,
x86@kernel.org, kaloz@openwrt.org, matt.fleming@intel.com,
lasse.collin@tukaani.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
linux-sh@vger.kernel.org, linux@arm.linux.org.uk,
schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com,
linux390@de.ibm.com
Subject: Re: [PATCH] lib/decompress_unxz.c: removing all memory helper functions
Date: Thu, 24 May 2012 10:29:26 -0700 [thread overview]
Message-ID: <4FBE6FF6.5090904@zytor.com> (raw)
In-Reply-To: <1337880371.5070.24.camel@joe2Laptop>
On 05/24/2012 10:26 AM, Joe Perches wrote:
> On Thu, 2012-05-24 at 10:03 -0600, T Makphaibulchoke wrote:
>> The patch cleans up the file lib/decompress_unxz.c by removing all memory
>> helper functions, e.g., memmove. By doing so, any architecture's preboot
>> environment supporting the XZ decompression needs to define its own copy of
>> any of the missing memory helper functions.
>
> Perhaps a silly question, but why not use
> the __builtin variants?
For a lot of cases the __builtin variants just generate a call to the
expected out-of-line function, so you need it anyway.
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
next prev parent reply other threads:[~2012-05-24 17:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-24 16:03 [PATCH] lib/decompress_unxz.c: removing all memory helper functions T Makphaibulchoke
2012-05-24 17:26 ` Joe Perches
2012-05-24 17:29 ` H. Peter Anvin [this message]
2012-05-24 17:40 ` Joe Perches
2012-05-24 17:41 ` H. Peter Anvin
2012-05-24 17:50 ` Joe Perches
2012-05-24 17:56 ` H. Peter Anvin
2012-05-25 8:34 ` Lasse Collin
2012-05-25 16:31 ` Thavatchai Makphaibulcboke
2012-05-25 17:05 ` Thavatchai Makphaibulcboke
2012-05-25 17:13 ` H. Peter Anvin
2012-05-25 19:35 ` Lasse Collin
2012-05-28 7:03 ` Jean-Christophe PLAGNIOL-VILLARD
2012-06-01 2:48 ` Thavatchai Makphaibulcboke
2012-06-01 2:54 ` Joe Perches
2012-06-01 3:38 ` H. Peter Anvin
2012-06-01 18:37 ` Thavatchai Makphaibulcboke
2012-06-01 18:46 ` H. Peter Anvin
2012-06-01 18:58 ` Thavatchai Makphaibulcboke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FBE6FF6.5090904@zytor.com \
--to=hpa@zytor.com \
--cc=heiko.carstens@de.ibm.com \
--cc=joe@perches.com \
--cc=kaloz@openwrt.org \
--cc=lasse.collin@tukaani.org \
--cc=lethal@linux-sh.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux390@de.ibm.com \
--cc=linux@arm.linux.org.uk \
--cc=matt.fleming@intel.com \
--cc=mingo@redhat.com \
--cc=schwidefsky@de.ibm.com \
--cc=tglx@linutronix.de \
--cc=tmac@hp.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox