pwc driver bugs

pwc driver bugs

[Udo van den Heuvel]

Hello,

I discovered some issues in the pwc driver for certain USB webcams.
I opened some bugs[1].
I do think both issues might be related and the crash issue is quite
serious.

Please have a look, I can assist by testing any patches with fixes. (for
~3.3.7)

Kind regards,
Udo


[1]: https://bugzilla.kernel.org/show_bug.cgi?id=43291  		
     https://bugzilla.kernel.org/show_bug.cgi?id=43290

Re: pwc driver bugs

[Alan Cox]

On Thu, 24 May 2012 17:03:49 +0200
Udo van den Heuvel <udovdh@xs4all.nl> wrote:

> Hello,
> 
> I discovered some issues in the pwc driver for certain USB webcams.
> I opened some bugs[1].
> I do think both issues might be related and the crash issue is quite
> serious.
> 
> Please have a look, I can assist by testing any patches with fixes. (for
> ~3.3.7)

commit ceede9fa8939e40ad0ddb4ad1355f45c6f1d3478

looks rather relevant here.

commit ceede9fa8939e40ad0ddb4ad1355f45c6f1d3478
Author: Hans de Goede <hdegoede@redhat.com>
Date:   Wed May 9 04:43:12 2012 -0300

    [media] pwc: Fix locking
    
    My last locking rework for pwc mistakenly assumed that videbuf2 does
    its own locking, but it does not! This patch fixes the missing
    locking by moving over the the video_device lock, and introducing a
    separate lock for the videobuf2_queue.
    
    Signed-off-by: Hans de Goede <hdegoede@redhat.com>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

Re: pwc driver bugs

[Udo van den Heuvel]

On 2012-05-24 17:56, Alan Cox wrote:
> commit ceede9fa8939e40ad0ddb4ad1355f45c6f1d3478
> 
> looks rather relevant here.

The commit does not apply cleanly to 3.3.7.
What are the dependencies for this patch to apply, so I can try to test
this code?

Kind regards,
Udo

Re: pwc driver bugs

[Hans de Goede]

Alan,

Thanks for adding me to the CC on this. Udo, I've
responded to your bugs in bugzilla.

Regards,

Hans


On 05/24/2012 05:56 PM, Alan Cox wrote:
> On Thu, 24 May 2012 17:03:49 +0200
> Udo van den Heuvel<udovdh@xs4all.nl>  wrote:
>
>> Hello,
>>
>> I discovered some issues in the pwc driver for certain USB webcams.
>> I opened some bugs[1].
>> I do think both issues might be related and the crash issue is quite
>> serious.
>>
>> Please have a look, I can assist by testing any patches with fixes. (for
>> ~3.3.7)
>
> commit ceede9fa8939e40ad0ddb4ad1355f45c6f1d3478
>
> looks rather relevant here.
>
> commit ceede9fa8939e40ad0ddb4ad1355f45c6f1d3478
> Author: Hans de Goede<hdegoede@redhat.com>
> Date:   Wed May 9 04:43:12 2012 -0300
>
>      [media] pwc: Fix locking
>
>      My last locking rework for pwc mistakenly assumed that videbuf2 does
>      its own locking, but it does not! This patch fixes the missing
>      locking by moving over the the video_device lock, and introducing a
>      separate lock for the videobuf2_queue.
>
>      Signed-off-by: Hans de Goede<hdegoede@redhat.com>
>      Signed-off-by: Mauro Carvalho Chehab<mchehab@redhat.com>