public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Tao Ma <tm@tao.ma>
To: peterz@infradead.org, mingo@kernel.org,
	LKML <linux-kernel@vger.kernel.org>, Sha <handai.szj@gmail.com>
Subject: 3.4: nohz load accounting still has some problem
Date: Fri, 25 May 2012 10:52:07 +0800	[thread overview]
Message-ID: <4FBEF3D7.60505@tao.ma> (raw)

Hi Peter,
	With 3.4 we still has problems with nohz load accounting. In one of our
product system, the number of running processes is around 16, but
loadavg is only around 8-10.  Without your fix c308b56b5, it is only
less than 1... Your patch does work, but not good enough. :(

After some investigation, it seems that we still have a hole, but we and
not sure and haven't figure out how to resolve it. So maybe you have a
good idea of whether our analysis is good and how to fix it.

So in general after your fix c308b56b5, we will fold the nohz remainder
to the global one after all the cpu has calculated the real value. But
there does exist some case: See
cpu 0     1                        2
    calc  calc

          idle and update
          calc_load_tasks_idle

                                   calc

Now when cpu2 calculates load, it will use calc_load_tasks_idle which
has been changed by cpu1. So the load isn't accurate any more. Am I
missing something here?

Thanks
Tao

                 reply	other threads:[~2012-05-25  2:52 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FBEF3D7.60505@tao.ma \
    --to=tm@tao.ma \
    --cc=handai.szj@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox