From: YOSHIDA Masanori <masanori.yoshida.tv@hitachi.com>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Vivek Goyal <vgoyal@redhat.com>,
linux-kernel@vger.kernel.org, Andy Lutomirski <luto@mit.edu>,
Ingo Molnar <mingo@elte.hu>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Kees Cook <keescook@chromium.org>, Kevin Hilman <khilman@ti.com>,
Prarit Bhargava <prarit@redhat.com>,
"Rafael J. Wysocki" <rjw@sisk.pl>, Tejun Heo <tj@kernel.org>,
yrl.pp-manager.tt@hitachi.com
Subject: Re: [RFC PATCH 1/4 V2] livedump: Add notifier-call-chain into do_page_fault
Date: Fri, 25 May 2012 21:14:55 +0900 [thread overview]
Message-ID: <4FBF77BF.1040304@hitachi.com> (raw)
In-Reply-To: <1337937596.9783.165.camel@laptop>
Hi, Peter,
I agree that notifier isn't suitable for this purpose.
In the next version, I plan to replace this with a simple
callback as follows.
if (very_unlikely(under_live_dump))
...
In addition to this, since PF handler is a very hot path,
I will cover the condition with "#ifdef CONFIG_WRPROTECT".
Thank you.
On 2012/05/25 18:19, Peter Zijlstra wrote:
> On Fri, 2012-05-25 at 18:12 +0900, YOSHIDA Masanori wrote:
>>
>> This patch adds notifier-call-chain that is called in do_page_fault.
>> Livedump uses this to check if page fault is caused by livedump, and if so,
>> the fault is handled by livedump's handler function. Otherwise, it is
>> handled by the original page fault handler.
>
> No, please no notifiers..
>
>
>
next prev parent reply other threads:[~2012-05-25 12:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-25 9:12 [RFC PATCH 0/4 V2] introduce: livedump YOSHIDA Masanori
2012-05-25 9:12 ` [RFC PATCH 3/4 V2] livedump: Add write protection management YOSHIDA Masanori
2012-05-25 9:12 ` [RFC PATCH 2/4 V2] livedump: Add the new misc device "livedump" YOSHIDA Masanori
2012-05-25 9:12 ` [RFC PATCH 1/4 V2] livedump: Add notifier-call-chain into do_page_fault YOSHIDA Masanori
2012-05-25 9:19 ` Peter Zijlstra
2012-05-25 12:14 ` YOSHIDA Masanori [this message]
2012-05-25 9:12 ` [RFC PATCH 4/4 V2] livedump: Add memory dumping functionality YOSHIDA Masanori
2012-05-25 9:25 ` [RFC PATCH 0/4 V2] introduce: livedump Peter Zijlstra
2012-05-25 11:12 ` YOSHIDA Masanori
2012-06-04 21:09 ` Vivek Goyal
2012-06-05 9:50 ` YOSHIDA Masanori
2012-06-04 21:29 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FBF77BF.1040304@hitachi.com \
--to=masanori.yoshida.tv@hitachi.com \
--cc=a.p.zijlstra@chello.nl \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=khilman@ti.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@mit.edu \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=prarit@redhat.com \
--cc=rjw@sisk.pl \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=vgoyal@redhat.com \
--cc=x86@kernel.org \
--cc=yrl.pp-manager.tt@hitachi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox