[PATCH] perf record: fix branch_stack type in perf_record_opts

[PATCH] perf record: fix branch_stack type in perf_record_opts

[Stephane Eranian]

The attr.branch_sample_type field is defined as u64 by the API.
As such, we need to ensure the variable holding the value of the
branch stack filters is also u64 otherwise we may lose bits in
the future.

Note also that the bogus definition of the field in
perf_record_opts caused problems on big-endian PPC systems.
Thanks to Anshuman Khandual for tracking the problem on PPC.

Signed-off-by: Stephane Eranian <eranian@google.com>
---

diff --git a/tools/perf/perf.h b/tools/perf/perf.h
index 14f1034..f960ccb 100644
--- a/tools/perf/perf.h
+++ b/tools/perf/perf.h
@@ -227,7 +227,7 @@ struct perf_record_opts {
 	unsigned int freq;
 	unsigned int mmap_pages;
 	unsigned int user_freq;
-	int	     branch_stack;
+	u64          branch_stack;
 	u64	     default_interval;
 	u64	     user_interval;
 };

Re: [PATCH] perf record: fix branch_stack type in perf_record_opts

[Anshuman Khandual]

On Saturday 26 May 2012 02:43 AM, Stephane Eranian wrote:

> 
> The attr.branch_sample_type field is defined as u64 by the API.
> As such, we need to ensure the variable holding the value of the
> branch stack filters is also u64 otherwise we may lose bits in
> the future.
> 
> Note also that the bogus definition of the field in
> perf_record_opts caused problems on big-endian PPC systems.
> Thanks to Anshuman Khandual for tracking the problem on PPC.
> 
> Signed-off-by: Stephane Eranian <eranian@google.com>


Acked-by: Anshuman Khandual <khandual@linux.vnet.ibm.com>

> ---
> 
> diff --git a/tools/perf/perf.h b/tools/perf/perf.h
> index 14f1034..f960ccb 100644
> --- a/tools/perf/perf.h
> +++ b/tools/perf/perf.h
> @@ -227,7 +227,7 @@ struct perf_record_opts {
>  	unsigned int freq;
>  	unsigned int mmap_pages;
>  	unsigned int user_freq;
> -	int	     branch_stack;
> +	u64          branch_stack;
>  	u64	     default_interval;
>  	u64	     user_interval;
>  };
> 

[tip:perf/urgent] perf record: Fix branch_stack type in perf_record_opts

[tip-bot for Stephane Eranian]

Commit-ID:  a00dc319e98161949aa87f71a17db32e925c3257
Gitweb:     http://git.kernel.org/tip/a00dc319e98161949aa87f71a17db32e925c3257
Author:     Stephane Eranian <eranian@google.com>
AuthorDate: Fri, 25 May 2012 23:13:44 +0200
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Fri, 25 May 2012 18:32:44 -0300

perf record: Fix branch_stack type in perf_record_opts

The attr.branch_sample_type field is defined as u64 by the API.  As
such, we need to ensure the variable holding the value of the branch
stack filters is also u64 otherwise we may lose bits in the future.

Note also that the bogus definition of the field in perf_record_opts
caused problems on big-endian PPC systems.  Thanks to Anshuman Khandual
for tracking the problem on PPC.

Reported-by: Anshuman Khandual <khandual@linux.vnet.ibm.com>
Signed-off-by: Stephane Eranian <eranian@google.com>
Cc: Anshuman Khandual <khandual@linux.vnet.ibm.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/20120525211344.GA7729@quad
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/perf.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/tools/perf/perf.h b/tools/perf/perf.h
index 14f1034..f960ccb 100644
--- a/tools/perf/perf.h
+++ b/tools/perf/perf.h
@@ -227,7 +227,7 @@ struct perf_record_opts {
 	unsigned int freq;
 	unsigned int mmap_pages;
 	unsigned int user_freq;
-	int	     branch_stack;
+	u64          branch_stack;
 	u64	     default_interval;
 	u64	     user_interval;
 };