From: Stephen Boyd <sboyd@codeaurora.org>
To: Anton Vorontsov <anton.vorontsov@linaro.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Kees Cook <keescook@chromium.org>,
Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>,
Arnd Bergmann <arnd@arndb.de>,
John Stultz <john.stultz@linaro.org>,
Shuah Khan <shuahkhan@gmail.com>,
arve@android.com, Rebecca Schultz Zavin <rebecca@android.com>,
Jesper Juhl <jj@chaosbits.net>,
Randy Dunlap <rdunlap@xenotime.net>,
Thomas Meyer <thomas@m3y3r.de>,
Andrew Morton <akpm@linux-foundation.org>,
Marco Stornelli <marco.stornelli@gmail.com>,
WANG Cong <xiyou.wangcong@gmail.com>,
linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
linaro-kernel@lists.linaro.org, patches@linaro.org,
kernel-team@android.com
Subject: Re: [PATCH 03/11] pstore/ram: Factor dmesg przs initialization out of probe()
Date: Tue, 29 May 2012 00:32:08 -0700 [thread overview]
Message-ID: <4FC47B78.2060003@codeaurora.org> (raw)
In-Reply-To: <1338038429-21945-3-git-send-email-anton.vorontsov@linaro.org>
On 5/26/2012 6:20 AM, Anton Vorontsov wrote:
> +static int ramoops_init_przs(struct device *dev, struct ramoops_context *cxt,
> + phys_addr_t *paddr, size_t dump_mem_sz)
> +{
> + int err = -ENOMEM;
> + int i;
> +
> + if (!cxt->record_size)
> + return 0;
> +
> + cxt->max_dump_cnt = dump_mem_sz / cxt->record_size;
> + if (!cxt->max_dump_cnt)
> + return -ENOMEM;
> +
> + cxt->przs = kzalloc(sizeof(*cxt->przs) * cxt->max_dump_cnt,
> + GFP_KERNEL);
kcalloc would be better but I see you're just moving code here so it
doesn't need to be changed in this patch.
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
next prev parent reply other threads:[~2012-05-29 7:32 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-26 13:17 [PATCH v5 0/11] Merge ram_console into pstore Anton Vorontsov
2012-05-26 13:20 ` [PATCH 01/11] pstore: Add console log messages support Anton Vorontsov
2012-05-26 13:20 ` [PATCH 02/11] pstore/ram: Give proper names to dump-related variables Anton Vorontsov
2012-05-30 17:57 ` Kees Cook
2012-05-26 13:20 ` [PATCH 03/11] pstore/ram: Factor dmesg przs initialization out of probe() Anton Vorontsov
2012-05-29 7:32 ` Stephen Boyd [this message]
2012-05-26 13:20 ` [PATCH 04/11] pstore/ram: Factor ramoops_get_next_prz() out of ramoops_pstore_read() Anton Vorontsov
2012-05-30 17:58 ` Kees Cook
2012-05-26 13:20 ` [PATCH 05/11] pstore/ram: Add console messages handling Anton Vorontsov
2012-05-26 13:20 ` [PATCH 06/11] pstore/ram_core: Silence some printks Anton Vorontsov
2012-05-26 13:20 ` [PATCH 07/11] pstore/ram: Add some more documentation and examples Anton Vorontsov
2012-05-26 13:20 ` [PATCH 08/11] staging/android: Remove ram_console driver Anton Vorontsov
2012-05-26 13:20 ` [PATCH 09/11] pstore/ram_core: Remove now unused code Anton Vorontsov
2012-05-26 13:20 ` [PATCH 10/11] pstore/platform: Make automatic updates interval configurable Anton Vorontsov
2012-05-26 13:20 ` [PATCH 11/11] pstore/platform: Disable automatic updates by default Anton Vorontsov
2012-06-14 0:05 ` [PATCH v5 0/11] Merge ram_console into pstore Greg Kroah-Hartman
2012-06-14 0:12 ` John Stultz
2012-06-14 0:20 ` Greg Kroah-Hartman
2012-06-14 0:29 ` John Stultz
2012-06-14 0:35 ` Anton Vorontsov
2012-06-14 0:22 ` Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FC47B78.2060003@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=akpm@linux-foundation.org \
--cc=anton.vorontsov@linaro.org \
--cc=arnd@arndb.de \
--cc=arve@android.com \
--cc=ccross@android.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jj@chaosbits.net \
--cc=john.stultz@linaro.org \
--cc=keescook@chromium.org \
--cc=kernel-team@android.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marco.stornelli@gmail.com \
--cc=patches@linaro.org \
--cc=rdunlap@xenotime.net \
--cc=rebecca@android.com \
--cc=shuahkhan@gmail.com \
--cc=thomas@m3y3r.de \
--cc=tony.luck@intel.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox