* [PATCH] mfd: Remove config AB8500_I2C_CORE Kconfig entry @ 2012-05-29 6:19 Axel Lin 2012-05-29 7:38 ` Lee Jones 0 siblings, 1 reply; 10+ messages in thread From: Axel Lin @ 2012-05-29 6:19 UTC (permalink / raw) To: linux-kernel; +Cc: Lee Jones, Samuel Ortiz, Linus Walleij config AB8500_I2C_CORE is not used after commit d28f1db "mfd: Remove confusing ab8500-i2c file and merge into ab8500-core". Thus remove it. Signed-off-by: Axel Lin <axel.lin@gmail.com> --- drivers/mfd/Kconfig | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig index e129c82..170072e 100644 --- a/drivers/mfd/Kconfig +++ b/drivers/mfd/Kconfig @@ -703,16 +703,6 @@ config AB8500_CORE the irq_chip parts for handling the Mixed Signal chip events. This chip embeds various other multimedia funtionalities as well. -config AB8500_I2C_CORE - bool "AB8500 register access via PRCMU I2C" - depends on AB8500_CORE && MFD_DB8500_PRCMU - default y - help - This enables register access to the AB8500 chip via PRCMU I2C. - The AB8500 chip can be accessed via SPI or I2C. On DB8500 hardware - the I2C bus is connected to the Power Reset - and Mangagement Unit, PRCMU. - config AB8500_DEBUG bool "Enable debug info via debugfs" depends on AB8500_CORE && DEBUG_FS -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] mfd: Remove config AB8500_I2C_CORE Kconfig entry 2012-05-29 6:19 [PATCH] mfd: Remove config AB8500_I2C_CORE Kconfig entry Axel Lin @ 2012-05-29 7:38 ` Lee Jones 2012-05-29 7:53 ` Axel Lin 0 siblings, 1 reply; 10+ messages in thread From: Lee Jones @ 2012-05-29 7:38 UTC (permalink / raw) To: Axel Lin; +Cc: linux-kernel, Samuel Ortiz, Linus Walleij On 29/05/12 14:19, Axel Lin wrote: > config AB8500_I2C_CORE is not used after commit d28f1db > "mfd: Remove confusing ab8500-i2c file and merge into ab8500-core". > Thus remove it. > > Signed-off-by: Axel Lin<axel.lin@gmail.com> I have this patch embedded into a patch-set I'm going to send to ARM-SoC for inclusion into -rc1 this afternoon. Would you mind leaving this one? -- Lee Jones Linaro ST-Ericsson Landing Team Lead M: +44 77 88 633 515 Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] mfd: Remove config AB8500_I2C_CORE Kconfig entry 2012-05-29 7:38 ` Lee Jones @ 2012-05-29 7:53 ` Axel Lin 2012-05-29 8:29 ` Lee Jones 0 siblings, 1 reply; 10+ messages in thread From: Axel Lin @ 2012-05-29 7:53 UTC (permalink / raw) To: Lee Jones; +Cc: linux-kernel, Samuel Ortiz, Linus Walleij 2012/5/29 Lee Jones <lee.jones@linaro.org>: > On 29/05/12 14:19, Axel Lin wrote: >> >> config AB8500_I2C_CORE is not used after commit d28f1db >> "mfd: Remove confusing ab8500-i2c file and merge into ab8500-core". >> Thus remove it. >> >> Signed-off-by: Axel Lin<axel.lin@gmail.com> > > > I have this patch embedded into a patch-set I'm going to send to ARM-SoC for > inclusion into -rc1 this afternoon. Would you mind leaving this one? I don't mind. But AFAIK, commit d28f1db is in mfd tree. Any reason you want to send the patch to ARM-SoC instead of mfd tree. Regards, Axel ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] mfd: Remove config AB8500_I2C_CORE Kconfig entry 2012-05-29 7:53 ` Axel Lin @ 2012-05-29 8:29 ` Lee Jones 2012-05-29 9:15 ` Samuel Ortiz 0 siblings, 1 reply; 10+ messages in thread From: Lee Jones @ 2012-05-29 8:29 UTC (permalink / raw) To: axel.lin; +Cc: linux-kernel, Samuel Ortiz, Linus Walleij On 29/05/12 15:53, Axel Lin wrote: > 2012/5/29 Lee Jones<lee.jones@linaro.org>: >> On 29/05/12 14:19, Axel Lin wrote: >>> >>> config AB8500_I2C_CORE is not used after commit d28f1db >>> "mfd: Remove confusing ab8500-i2c file and merge into ab8500-core". >>> Thus remove it. >>> >>> Signed-off-by: Axel Lin<axel.lin@gmail.com> >> >> >> I have this patch embedded into a patch-set I'm going to send to ARM-SoC for >> inclusion into -rc1 this afternoon. Would you mind leaving this one? > > I don't mind. > But AFAIK, commit d28f1db is in mfd tree. > Any reason you want to send the patch to ARM-SoC instead of mfd tree. I don't actually have a preference as to which tree it goes into, so long as it's sent to Mainline on or before -rc1. This patch isn't too important, but the others in the patch-set are and I'd like to keep them together if possible. Unless of course Sam or Mark have any issues with that. In which case I will bow down to them and do as they wish. Kind regards, Lee -- Lee Jones Linaro ST-Ericsson Landing Team Lead M: +44 77 88 633 515 Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] mfd: Remove config AB8500_I2C_CORE Kconfig entry 2012-05-29 8:29 ` Lee Jones @ 2012-05-29 9:15 ` Samuel Ortiz 2012-05-29 9:27 ` Lee Jones 0 siblings, 1 reply; 10+ messages in thread From: Samuel Ortiz @ 2012-05-29 9:15 UTC (permalink / raw) To: Lee Jones; +Cc: axel.lin, linux-kernel, Linus Walleij Hi Lee, On Tue, May 29, 2012 at 04:29:21PM +0800, Lee Jones wrote: > On 29/05/12 15:53, Axel Lin wrote: > >2012/5/29 Lee Jones<lee.jones@linaro.org>: > >>On 29/05/12 14:19, Axel Lin wrote: > >>> > >>>config AB8500_I2C_CORE is not used after commit d28f1db > >>>"mfd: Remove confusing ab8500-i2c file and merge into ab8500-core". > >>>Thus remove it. > >>> > >>>Signed-off-by: Axel Lin<axel.lin@gmail.com> > >> > >> > >>I have this patch embedded into a patch-set I'm going to send to ARM-SoC for > >>inclusion into -rc1 this afternoon. Would you mind leaving this one? > > > >I don't mind. > >But AFAIK, commit d28f1db is in mfd tree. > >Any reason you want to send the patch to ARM-SoC instead of mfd tree. > > I don't actually have a preference as to which tree it goes into, so > long as it's sent to Mainline on or before -rc1. I sent a pull request to Linus yesterday, including this commit. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] mfd: Remove config AB8500_I2C_CORE Kconfig entry 2012-05-29 9:15 ` Samuel Ortiz @ 2012-05-29 9:27 ` Lee Jones 2012-05-29 10:52 ` Samuel Ortiz 0 siblings, 1 reply; 10+ messages in thread From: Lee Jones @ 2012-05-29 9:27 UTC (permalink / raw) To: Samuel Ortiz; +Cc: axel.lin, linux-kernel, Linus Walleij Hi Sam, > On Tue, May 29, 2012 at 04:29:21PM +0800, Lee Jones wrote: >> On 29/05/12 15:53, Axel Lin wrote: >>> 2012/5/29 Lee Jones<lee.jones@linaro.org>: >>>> On 29/05/12 14:19, Axel Lin wrote: >>>>> >>>>> config AB8500_I2C_CORE is not used after commit d28f1db >>>>> "mfd: Remove confusing ab8500-i2c file and merge into ab8500-core". >>>>> Thus remove it. >>>>> >>>>> Signed-off-by: Axel Lin<axel.lin@gmail.com> >>>> >>>> >>>> I have this patch embedded into a patch-set I'm going to send to ARM-SoC for >>>> inclusion into -rc1 this afternoon. Would you mind leaving this one? >>> >>> I don't mind. >>> But AFAIK, commit d28f1db is in mfd tree. >>> Any reason you want to send the patch to ARM-SoC instead of mfd tree. >> >> I don't actually have a preference as to which tree it goes into, so >> long as it's sent to Mainline on or before -rc1. > I sent a pull request to Linus yesterday, including this commit. This is something different and wasn't part of the pull-request. Kind regards, Lee -- Lee Jones Linaro ST-Ericsson Landing Team Lead M: +44 77 88 633 515 Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] mfd: Remove config AB8500_I2C_CORE Kconfig entry 2012-05-29 9:27 ` Lee Jones @ 2012-05-29 10:52 ` Samuel Ortiz 2012-05-29 15:06 ` Lee Jones 0 siblings, 1 reply; 10+ messages in thread From: Samuel Ortiz @ 2012-05-29 10:52 UTC (permalink / raw) To: Lee Jones; +Cc: axel.lin, linux-kernel, Linus Walleij Hi Lee, On Tue, May 29, 2012 at 05:27:22PM +0800, Lee Jones wrote: > Hi Sam, > > >On Tue, May 29, 2012 at 04:29:21PM +0800, Lee Jones wrote: > >>On 29/05/12 15:53, Axel Lin wrote: > >>>2012/5/29 Lee Jones<lee.jones@linaro.org>: > >>>>On 29/05/12 14:19, Axel Lin wrote: > >>>>> > >>>>>config AB8500_I2C_CORE is not used after commit d28f1db > >>>>>"mfd: Remove confusing ab8500-i2c file and merge into ab8500-core". > >>>>>Thus remove it. > >>>>> > >>>>>Signed-off-by: Axel Lin<axel.lin@gmail.com> > >>>> > >>>> > >>>>I have this patch embedded into a patch-set I'm going to send to ARM-SoC for > >>>>inclusion into -rc1 this afternoon. Would you mind leaving this one? > >>> > >>>I don't mind. > >>>But AFAIK, commit d28f1db is in mfd tree. > >>>Any reason you want to send the patch to ARM-SoC instead of mfd tree. > >> > >>I don't actually have a preference as to which tree it goes into, so > >>long as it's sent to Mainline on or before -rc1. > >I sent a pull request to Linus yesterday, including this commit. > > This is something different and wasn't part of the pull-request. d28f1d was part of the pull request. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] mfd: Remove config AB8500_I2C_CORE Kconfig entry 2012-05-29 10:52 ` Samuel Ortiz @ 2012-05-29 15:06 ` Lee Jones 2012-05-29 15:27 ` Samuel Ortiz 0 siblings, 1 reply; 10+ messages in thread From: Lee Jones @ 2012-05-29 15:06 UTC (permalink / raw) To: Samuel Ortiz; +Cc: axel.lin, linux-kernel, Linus Walleij On 29/05/12 18:52, Samuel Ortiz wrote: > Hi Lee, > > On Tue, May 29, 2012 at 05:27:22PM +0800, Lee Jones wrote: >> Hi Sam, >> >>> On Tue, May 29, 2012 at 04:29:21PM +0800, Lee Jones wrote: >>>> On 29/05/12 15:53, Axel Lin wrote: >>>>> 2012/5/29 Lee Jones<lee.jones@linaro.org>: >>>>>> On 29/05/12 14:19, Axel Lin wrote: >>>>>>> >>>>>>> config AB8500_I2C_CORE is not used after commit d28f1db >>>>>>> "mfd: Remove confusing ab8500-i2c file and merge into ab8500-core". >>>>>>> Thus remove it. >>>>>>> >>>>>>> Signed-off-by: Axel Lin<axel.lin@gmail.com> >>>>>> >>>>>> >>>>>> I have this patch embedded into a patch-set I'm going to send to ARM-SoC for >>>>>> inclusion into -rc1 this afternoon. Would you mind leaving this one? >>>>> >>>>> I don't mind. >>>>> But AFAIK, commit d28f1db is in mfd tree. >>>>> Any reason you want to send the patch to ARM-SoC instead of mfd tree. >>>> >>>> I don't actually have a preference as to which tree it goes into, so >>>> long as it's sent to Mainline on or before -rc1. >>> I sent a pull request to Linus yesterday, including this commit. >> >> This is something different and wasn't part of the pull-request. > d28f1d was part of the pull request. Right. But this is not the same thing. The patch I (and Axel) wrote removes remnant cruft from d28f1d. I didn't see that on moving AB8500_I2C_CORE to AB8500_CORE I left a Kconfig entry behind which is no longer used by anything. This patch removes that cruft. Kind regards, Lee -- Lee Jones Linaro ST-Ericsson Landing Team Lead M: +44 77 88 633 515 Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] mfd: Remove config AB8500_I2C_CORE Kconfig entry 2012-05-29 15:06 ` Lee Jones @ 2012-05-29 15:27 ` Samuel Ortiz 2012-05-29 15:37 ` Lee Jones 0 siblings, 1 reply; 10+ messages in thread From: Samuel Ortiz @ 2012-05-29 15:27 UTC (permalink / raw) To: Lee Jones; +Cc: axel.lin, linux-kernel, Linus Walleij Hi Lee, On Tue, May 29, 2012 at 11:06:23PM +0800, Lee Jones wrote: > On 29/05/12 18:52, Samuel Ortiz wrote: > >Hi Lee, > > > >On Tue, May 29, 2012 at 05:27:22PM +0800, Lee Jones wrote: > >>Hi Sam, > >> > >>>On Tue, May 29, 2012 at 04:29:21PM +0800, Lee Jones wrote: > >>>>On 29/05/12 15:53, Axel Lin wrote: > >>>>>2012/5/29 Lee Jones<lee.jones@linaro.org>: > >>>>>>On 29/05/12 14:19, Axel Lin wrote: > >>>>>>> > >>>>>>>config AB8500_I2C_CORE is not used after commit d28f1db > >>>>>>>"mfd: Remove confusing ab8500-i2c file and merge into ab8500-core". > >>>>>>>Thus remove it. > >>>>>>> > >>>>>>>Signed-off-by: Axel Lin<axel.lin@gmail.com> > >>>>>> > >>>>>> > >>>>>>I have this patch embedded into a patch-set I'm going to send to ARM-SoC for > >>>>>>inclusion into -rc1 this afternoon. Would you mind leaving this one? > >>>>> > >>>>>I don't mind. > >>>>>But AFAIK, commit d28f1db is in mfd tree. > >>>>>Any reason you want to send the patch to ARM-SoC instead of mfd tree. > >>>> > >>>>I don't actually have a preference as to which tree it goes into, so > >>>>long as it's sent to Mainline on or before -rc1. > >>>I sent a pull request to Linus yesterday, including this commit. > >> > >>This is something different and wasn't part of the pull-request. > >d28f1d was part of the pull request. > > Right. But this is not the same thing. The patch I (and Axel) wrote > removes remnant cruft from d28f1d. I didn't see that on moving > AB8500_I2C_CORE to AB8500_CORE I left a Kconfig entry behind which > is no longer used by anything. This patch removes that cruft. Yes, I saw the patch. I though you were saying that d28f1d was not part of the pull request and that you were going to push it through arm-soc. Anyway, I think the Kconfig cleanup patch should go through my tree unless you already sent it for arm-soc inclusion. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] mfd: Remove config AB8500_I2C_CORE Kconfig entry 2012-05-29 15:27 ` Samuel Ortiz @ 2012-05-29 15:37 ` Lee Jones 0 siblings, 0 replies; 10+ messages in thread From: Lee Jones @ 2012-05-29 15:37 UTC (permalink / raw) To: Samuel Ortiz; +Cc: axel.lin, linux-kernel, Linus Walleij On 29/05/12 23:27, Samuel Ortiz wrote: > Hi Lee, > > On Tue, May 29, 2012 at 11:06:23PM +0800, Lee Jones wrote: >> On 29/05/12 18:52, Samuel Ortiz wrote: >>> Hi Lee, >>> >>> On Tue, May 29, 2012 at 05:27:22PM +0800, Lee Jones wrote: >>>> Hi Sam, >>>> >>>>> On Tue, May 29, 2012 at 04:29:21PM +0800, Lee Jones wrote: >>>>>> On 29/05/12 15:53, Axel Lin wrote: >>>>>>> 2012/5/29 Lee Jones<lee.jones@linaro.org>: >>>>>>>> On 29/05/12 14:19, Axel Lin wrote: >>>>>>>>> >>>>>>>>> config AB8500_I2C_CORE is not used after commit d28f1db >>>>>>>>> "mfd: Remove confusing ab8500-i2c file and merge into ab8500-core". >>>>>>>>> Thus remove it. >>>>>>>>> >>>>>>>>> Signed-off-by: Axel Lin<axel.lin@gmail.com> >>>>>>>> >>>>>>>> >>>>>>>> I have this patch embedded into a patch-set I'm going to send to ARM-SoC for >>>>>>>> inclusion into -rc1 this afternoon. Would you mind leaving this one? >>>>>>> >>>>>>> I don't mind. >>>>>>> But AFAIK, commit d28f1db is in mfd tree. >>>>>>> Any reason you want to send the patch to ARM-SoC instead of mfd tree. >>>>>> >>>>>> I don't actually have a preference as to which tree it goes into, so >>>>>> long as it's sent to Mainline on or before -rc1. >>>>> I sent a pull request to Linus yesterday, including this commit. >>>> >>>> This is something different and wasn't part of the pull-request. >>> d28f1d was part of the pull request. >> >> Right. But this is not the same thing. The patch I (and Axel) wrote >> removes remnant cruft from d28f1d. I didn't see that on moving >> AB8500_I2C_CORE to AB8500_CORE I left a Kconfig entry behind which >> is no longer used by anything. This patch removes that cruft. > Yes, I saw the patch. I though you were saying that d28f1d was not part of the > pull request and that you were going to push it through arm-soc. > Anyway, I think the Kconfig cleanup patch should go through my tree unless you > already sent it for arm-soc inclusion. I haven't. I sent the entire patch-set to Arnd for first review today. After he's okay:ed it, I'll send it to the MLs sometime tomorrow. I will ensure you are CC'ed. I don't have any issues with the patch going through your tree. Thanks Sam. Kind regards, Lee -- Lee Jones Linaro ST-Ericsson Landing Team Lead M: +44 77 88 633 515 Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2012-05-29 15:37 UTC | newest] Thread overview: 10+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2012-05-29 6:19 [PATCH] mfd: Remove config AB8500_I2C_CORE Kconfig entry Axel Lin 2012-05-29 7:38 ` Lee Jones 2012-05-29 7:53 ` Axel Lin 2012-05-29 8:29 ` Lee Jones 2012-05-29 9:15 ` Samuel Ortiz 2012-05-29 9:27 ` Lee Jones 2012-05-29 10:52 ` Samuel Ortiz 2012-05-29 15:06 ` Lee Jones 2012-05-29 15:27 ` Samuel Ortiz 2012-05-29 15:37 ` Lee Jones
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox