From: Glauber Costa <glommer@parallels.com>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: <linux-kernel@vger.kernel.org>, <cgroups@vger.kernel.org>,
<devel@openvz.org>, Paul Turner <pjt@google.com>,
Tejun Heo <tj@kernel.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
<handai.szj@gmail.com>, <Andrew.Phillips@lmax.com>,
Serge Hallyn <serge.hallyn@canonical.com>
Subject: Re: [PATCH v3 2/6] account guest time per-cgroup as well.
Date: Wed, 30 May 2012 14:36:27 +0400 [thread overview]
Message-ID: <4FC5F82B.6030404@parallels.com> (raw)
In-Reply-To: <1338373947.26856.240.camel@twins>
On 05/30/2012 02:32 PM, Peter Zijlstra wrote:
> On Wed, 2012-05-30 at 13:48 +0400, Glauber Costa wrote:
>> > We already track multiple tick statistics per-cgroup, using
>> > the task_group_account_field facility. This patch accounts
>> > guest_time in that manner as well.
> So this leaves IOWAIT and IDLE the only fields not using
> task_group_account_field(), right?
Yes, because they are essentially global, and their meaning is
ill-defined from within a cgroup.
If you look further out in the patchset, I intend to export idle from
cpu, instead of cpuacct, because something that can be used as idle
value is already computed anyway from the schedstats, so I'm just using it.
iowait will be left blank for now. Me and Paul agreed last time we
talked that it is not uber important to have iowait values per-cgroup.
next prev parent reply other threads:[~2012-05-30 10:38 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-30 9:48 [PATCH v3 0/6] per cgroup /proc/stat statistics Glauber Costa
2012-05-30 9:48 ` [PATCH v3 1/6] measure exec_clock for rt sched entities Glauber Costa
2012-05-30 10:29 ` Peter Zijlstra
2012-05-30 10:32 ` Glauber Costa
2012-05-30 10:42 ` Peter Zijlstra
2012-05-30 10:42 ` Glauber Costa
2012-05-30 11:00 ` Paul Turner
2012-05-30 12:09 ` Glauber Costa
2012-05-30 9:48 ` [PATCH v3 2/6] account guest time per-cgroup as well Glauber Costa
2012-05-30 10:32 ` Peter Zijlstra
2012-05-30 10:36 ` Glauber Costa [this message]
2012-05-30 10:46 ` Paul Turner
2012-05-30 9:48 ` [PATCH v3 3/6] expose fine-grained per-cpu data for cpuacct stats Glauber Costa
2012-05-30 10:34 ` Peter Zijlstra
2012-05-30 10:34 ` Glauber Costa
2012-05-30 10:43 ` Peter Zijlstra
2012-05-30 10:44 ` Glauber Costa
2012-05-30 11:24 ` Peter Zijlstra
2012-05-30 11:24 ` Paul Turner
2012-05-30 12:20 ` Glauber Costa
2012-05-30 12:48 ` Paul Turner
2012-05-30 12:52 ` Glauber Costa
2012-05-30 13:26 ` Glauber Costa
2012-05-30 13:26 ` Glauber Costa
2012-05-30 9:48 ` [PATCH v3 4/6] add a new scheduler hook for context switch Glauber Costa
2012-05-30 11:20 ` Peter Zijlstra
2012-05-30 11:40 ` Peter Zijlstra
2012-05-30 12:08 ` Glauber Costa
2012-05-30 12:07 ` Glauber Costa
2012-05-30 9:48 ` [PATCH v3 5/6] Also record sleep start for a task group Glauber Costa
2012-05-30 11:35 ` Paul Turner
2012-05-30 12:24 ` Glauber Costa
2012-05-30 12:44 ` Peter Zijlstra
2012-05-30 12:44 ` Glauber Costa
2012-05-30 9:48 ` [PATCH v3 6/6] expose per-taskgroup schedstats in cgroup Glauber Costa
2012-05-30 11:22 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FC5F82B.6030404@parallels.com \
--to=glommer@parallels.com \
--cc=Andrew.Phillips@lmax.com \
--cc=a.p.zijlstra@chello.nl \
--cc=cgroups@vger.kernel.org \
--cc=devel@openvz.org \
--cc=ebiederm@xmission.com \
--cc=handai.szj@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pjt@google.com \
--cc=serge.hallyn@canonical.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox