From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751797Ab2E3O67 (ORCPT ); Wed, 30 May 2012 10:58:59 -0400 Received: from terminus.zytor.com ([198.137.202.10]:39141 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750959Ab2E3O66 (ORCPT ); Wed, 30 May 2012 10:58:58 -0400 Message-ID: <4FC6358F.2010405@zytor.com> Date: Wed, 30 May 2012 07:58:23 -0700 From: "H. Peter Anvin" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: Borislav Petkov , Andre Przywara , mingo@elte.hu, tglx@linutronix.de, konrad.wilk@oracle.com, jeremy@goop.org, linux-kernel@vger.kernel.org, xen-devel@lists.xensource.com, stable@vger.kernel.org.#.3.4+ Subject: Re: [PATCH] x86/amd: fix crash as Xen Dom0 on AMD Trinity systems References: <1338383402-3838-1-git-send-email-andre.przywara@amd.com> <4FC631D3.9080907@zytor.com> <20120530145523.GA15635@x1.osrc.amd.com> In-Reply-To: <20120530145523.GA15635@x1.osrc.amd.com> X-Enigmail-Version: 1.4.1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/30/2012 07:55 AM, Borislav Petkov wrote: > On Wed, May 30, 2012 at 07:42:27AM -0700, H. Peter Anvin wrote: >> On 05/30/2012 06:10 AM, Andre Przywara wrote: >>> Because we are behind a family check before tweaking the topology >>> bit, we can use the standard rd/wrmsr variants for the CPUID feature >>> register. >> >> That is not what the *msr*_amd*() functions do. >> >> NAK. This is a totally bogus patch. > > The *msr*_amd*() variants were used instead of the normal *msrl_safe > variants although the AMD variants weren't needed there at all. > > This has no issue on baremetal but breaks xen and this is how we caught > this. > > So the patch corrects the original patch so that xen is happy too. > If so, then fix the description to match reality and we can take the patch. -hpa