From: Lee Jones <lee.jones@linaro.org>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Chris Ball <cjb@laptop.org>,
Linus Walleij <linus.walleij@stericsson.com>,
Bengt Jonsson <bengt.g.jonsson@stericsson.com>,
Mattias WALLIN <mattias.wallin@stericsson.com>,
linux-arm-kernel@lists.infradead.org, sameo@linux.intel.com,
grant.likely@secretlab.ca, linux-kernel@vger.kernel.org,
arnd@arndb.de, Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH 08/22] regulator: Change ab8500 match names to reflect Device Tree
Date: Thu, 31 May 2012 08:42:12 +0800 [thread overview]
Message-ID: <4FC6BE64.6030201@linaro.org> (raw)
In-Reply-To: <20120530164152.GP9947@opensource.wolfsonmicro.com>
On 31/05/12 00:41, Mark Brown wrote:
> On Wed, May 30, 2012 at 11:22:33PM +0800, Lee Jones wrote:
>> On 30/05/12 23:11, Mark Brown wrote:
>
>>>> vin-supply =<&db8500_vape_reg>;
>>>> vmmc-supply =<&ab8500_ldo_aux2_reg>;
>
>>> Oh, oops. This is going to be fun when someone puts down two of the
>>> same PMIC on a system...
>
>> What does that mean sorry?
>
> Lots of regulators are using this mechanism for identifying child nodes.
> If the node name is also used as a handle by other things to reference
> the regulator then if you have two PMICs of the same type DTC isn't
> going to be able to figure out which node you mean.
I haven't looked at the code yet, so I don't know the answer to this
question, but; aren't they protected by the compatible string? If not, I
think they should be. We shouldn't be parsing other platform's Device Trees.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
M: +44 77 88 633 515
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2012-05-31 0:42 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1338353260-10097-1-git-send-email-lee.jones@linaro.org>
2012-05-30 4:47 ` [PATCH 08/22] regulator: Change ab8500 match names to reflect Device Tree Lee Jones
2012-05-30 6:58 ` Linus Walleij
2012-05-30 10:03 ` Mark Brown
[not found] ` <CAF2Aj3gZMF9ev9B46rBM+aY-srwthef09ad2CWfuXXFHmqqAjA@mail.gmail.com>
2012-05-30 12:15 ` Mark Brown
2012-05-30 15:01 ` Lee Jones
2012-05-30 15:11 ` Mark Brown
2012-05-30 15:22 ` Lee Jones
2012-05-30 16:41 ` Mark Brown
2012-05-31 0:42 ` Lee Jones [this message]
2012-06-01 4:36 ` Lee Jones
2012-06-01 8:48 ` Mark Brown
2012-06-05 10:31 ` Lee Jones
2012-06-05 10:38 ` Mark Brown
2012-06-11 10:27 ` Lee Jones
2012-06-11 10:36 ` Mark Brown
2012-06-11 11:28 ` Lee Jones
2012-06-11 11:42 ` Mark Brown
2012-05-31 1:40 ` Linus Walleij
2012-06-01 14:32 ` Mark Brown
2012-05-30 4:47 ` [PATCH 09/22] regulator: Change db8500-prcmu " Lee Jones
2012-05-30 7:00 ` Linus Walleij
2012-06-05 10:24 ` Lee Jones
2012-06-05 10:29 ` Mark Brown
2012-06-05 10:34 ` Lee Jones
2012-06-05 10:42 ` Mark Brown
2012-06-11 11:21 ` Lee Jones
2012-06-11 12:08 ` Mark Brown
2012-06-11 13:34 ` Lee Jones
2012-06-11 14:07 ` Lee Jones
2012-06-11 14:27 ` Mark Brown
2012-06-11 14:50 ` Lee Jones
2012-06-11 15:15 ` Mark Brown
2012-06-11 15:18 ` Lee Jones
2012-06-11 15:39 ` Mark Brown
2012-06-11 15:59 ` Lee Jones
2012-06-11 16:09 ` Mark Brown
2012-05-30 4:47 ` [PATCH 16/22] mfd: ab8500-gpadc: Enable IRQF_ONESHOT when requesting a threaded IRQ Lee Jones
2012-05-30 7:10 ` Linus Walleij
2012-06-29 13:21 ` Samuel Ortiz
2012-05-30 4:47 ` [PATCH 18/22] mfd: Remove redundant Kconfig entry Lee Jones
2012-05-30 7:15 ` Linus Walleij
2012-05-30 7:37 ` Lee Jones
2012-05-30 7:43 ` Linus Walleij
2012-06-29 13:24 ` Samuel Ortiz
2012-05-30 4:47 ` [PATCH 22/22] mfd: Enable DT probing of the DB8500 PRCMU Lee Jones
2012-05-30 7:19 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FC6BE64.6030201@linaro.org \
--to=lee.jones@linaro.org \
--cc=arnd@arndb.de \
--cc=bengt.g.jonsson@stericsson.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=cjb@laptop.org \
--cc=grant.likely@secretlab.ca \
--cc=linus.walleij@linaro.org \
--cc=linus.walleij@stericsson.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mattias.wallin@stericsson.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).