From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756485Ab2EaAmT (ORCPT ); Wed, 30 May 2012 20:42:19 -0400 Received: from mail-pz0-f46.google.com ([209.85.210.46]:60204 "EHLO mail-pz0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753807Ab2EaAmS (ORCPT ); Wed, 30 May 2012 20:42:18 -0400 Message-ID: <4FC6BE64.6030201@linaro.org> Date: Thu, 31 May 2012 08:42:12 +0800 From: Lee Jones User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120410 Thunderbird/11.0.1 MIME-Version: 1.0 To: Mark Brown CC: Chris Ball , Linus Walleij , Bengt Jonsson , Mattias WALLIN , linux-arm-kernel@lists.infradead.org, sameo@linux.intel.com, grant.likely@secretlab.ca, linux-kernel@vger.kernel.org, arnd@arndb.de, Linus Walleij Subject: Re: [PATCH 08/22] regulator: Change ab8500 match names to reflect Device Tree References: <1338353260-10097-1-git-send-email-lee.jones@linaro.org> <1338353260-10097-9-git-send-email-lee.jones@linaro.org> <20120530100302.GD9947@opensource.wolfsonmicro.com> <20120530121547.GJ9947@opensource.wolfsonmicro.com> <4FC63632.4030504@linaro.org> <20120530151119.GN9947@opensource.wolfsonmicro.com> <4FC63B39.6040905@linaro.org> <20120530164152.GP9947@opensource.wolfsonmicro.com> In-Reply-To: <20120530164152.GP9947@opensource.wolfsonmicro.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 31/05/12 00:41, Mark Brown wrote: > On Wed, May 30, 2012 at 11:22:33PM +0800, Lee Jones wrote: >> On 30/05/12 23:11, Mark Brown wrote: > >>>> vin-supply =<&db8500_vape_reg>; >>>> vmmc-supply =<&ab8500_ldo_aux2_reg>; > >>> Oh, oops. This is going to be fun when someone puts down two of the >>> same PMIC on a system... > >> What does that mean sorry? > > Lots of regulators are using this mechanism for identifying child nodes. > If the node name is also used as a handle by other things to reference > the regulator then if you have two PMICs of the same type DTC isn't > going to be able to figure out which node you mean. I haven't looked at the code yet, so I don't know the answer to this question, but; aren't they protected by the compatible string? If not, I think they should be. We shouldn't be parsing other platform's Device Trees. -- Lee Jones Linaro ST-Ericsson Landing Team Lead M: +44 77 88 633 515 Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog