From: Alex Shi <alex.shi@intel.com>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: "Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>,
rusty@rustcorp.com.au, akpm@linux-foundation.org,
paul.gortmaker@windriver.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cpumask: add a few comments of cpumask functions
Date: Thu, 31 May 2012 16:15:25 +0800 [thread overview]
Message-ID: <4FC7289D.2080009@intel.com> (raw)
In-Reply-To: <CAHGf_=p=6t7Heyuio2t1q6Qb8KWCfnWzFjuR3kCO0VRTjiUBdA@mail.gmail.com>
On 05/30/2012 06:49 PM, KOSAKI Motohiro wrote:
> On Wed, May 30, 2012 at 6:40 AM, Alex Shi <alex.shi@intel.com> wrote:
>> On 05/29/2012 09:16 AM, Alex Shi wrote:
>>
>>>
>>>>>> s/return/Returns
>>>>>>
>>>>>> What do you mean by "old" cpumask?
>>>>>
>>>>> Thanks for comments!
>>>>> Should be "the old bitmap of cpumask"?
>>>>>
>>>>
>>>>
>>>> No, there is no "old" or "new" cpumask here because this function doesn't
>>>> change the cpumask. It just checks if that bit is set.
>>>> So something like:
>>>> Returns 1 if 'cpu' is set in 'cpumask', else returns 0.
>>>>
>>>
>>>
>>>
>>> Sure, thanks! and comments changed again following your style.
>>> Is the following new update patch ok?
>>
>>
>> Any further comments for this patch? :)
>
> Acked-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Thanks!
Does someone like to pick up this patch? :)
next prev parent reply other threads:[~2012-05-31 8:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-28 9:02 [PATCH] cpumask: add a few comments of cpumask functions Alex Shi
2012-05-28 12:47 ` Srivatsa S. Bhat
2012-05-28 13:49 ` Alex Shi
2012-05-28 14:23 ` Alex Shi
2012-07-13 22:37 ` Andrew Morton
2012-07-16 2:34 ` Alex Shi
2012-07-16 7:35 ` Rusty Russell
2012-07-16 8:01 ` Alex Shi
2012-05-28 15:25 ` Srivatsa S. Bhat
2012-05-29 1:16 ` Alex Shi
2012-05-30 10:40 ` Alex Shi
2012-05-30 10:49 ` KOSAKI Motohiro
2012-05-31 8:15 ` Alex Shi [this message]
2012-06-04 1:37 ` Rusty Russell
2012-06-04 1:36 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FC7289D.2080009@intel.com \
--to=alex.shi@intel.com \
--cc=akpm@linux-foundation.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=rusty@rustcorp.com.au \
--cc=srivatsa.bhat@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).