From: KOSAKI Motohiro <kosaki.motohiro@gmail.com>
To: James Morris <jmorris@namei.org>
Cc: kosaki.motohiro@gmail.com, linux-kernel@vger.kernel.org,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Vasiliy Kulikov <segoon@openwall.com>,
Chris Wright <chrisw@sous-sol.org>,
James Morris <james.l.morris@oracle.com>,
linux-security-module@vger.kernel.org,
Serge Hallyn <serge.hallyn@canonical.com>
Subject: Re: [PATCH] security: kill security_task_fix_setuid()
Date: Thu, 31 May 2012 04:51:06 -0400 [thread overview]
Message-ID: <4FC730FA.8080305@gmail.com> (raw)
In-Reply-To: <alpine.LRH.2.02.1205311841530.26474@tundra.namei.org>
(5/31/12 4:42 AM), James Morris wrote:
> On Thu, 31 May 2012, kosaki.motohiro@gmail.com wrote:
>
>> From: KOSAKI Motohiro<kosaki.motohiro@jp.fujitsu.com>
>>
>> commit 72fa5997 (move RLIMIT_NPROC check from set_user() to do_execve_common())
>> pointed out set*uid() failure can cause a security problem.
>> Thus, security_task_fix_setuid() potentially has the same issue. Any security
>> module shouldn't use it. This patch kills it completely.
>>
>> Luckily, any security module don't use it. then, this patch doesn't make any
>> userland visible change.
>
> Capabilities uses it.
Oops, I overlooked. Please ignore this patch. sorry.
prev parent reply other threads:[~2012-05-31 8:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-31 7:59 [PATCH] security: kill security_task_fix_setuid() kosaki.motohiro
2012-05-31 8:42 ` James Morris
2012-05-31 8:51 ` KOSAKI Motohiro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FC730FA.8080305@gmail.com \
--to=kosaki.motohiro@gmail.com \
--cc=chrisw@sous-sol.org \
--cc=james.l.morris@oracle.com \
--cc=jmorris@namei.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=segoon@openwall.com \
--cc=serge.hallyn@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox