From: "H. Peter Anvin" <hpa@zytor.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: konrad@darnok.org, linux-kernel@vger.kernel.org, x86@kernel.org,
mingo@redhat.com, tglx@linutronix.de, stable@kernel.org
Subject: Re: [PATCH] x86/i386: Check PSE bit before using PAGE_KERNEL_LARGE.
Date: Thu, 31 May 2012 13:21:02 -0700 [thread overview]
Message-ID: <4FC7D2AE.9080603@zytor.com> (raw)
In-Reply-To: <1338493218-25006-1-git-send-email-konrad.wilk@oracle.com>
On 05/31/2012 12:40 PM, Konrad Rzeszutek Wilk wrote:
> During bootup we would unconditionally do this on any
> machine that was built with CONFIG_NUMA=y on i386:
>
> setup_arch
> \-initmem_init
> \-x86_numa_init (with dummy_init as callback)
> \- init_alloc_remap
> \- set_pmd_pfn (with PAGE_PSE)
>
> without checking to see if the CPU supports PSE. This
> patch adds that and also allows the init_alloc_remap function
> to properly work by falling back on PTEs.
>
Well, the code looks like it is PAE-specific, and PAE implies PSE.
Xen breaks that, but that is a divergence of Xen from x86.
-hpa
next prev parent reply other threads:[~2012-05-31 20:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-31 19:40 [PATCH] x86/i386: Check PSE bit before using PAGE_KERNEL_LARGE Konrad Rzeszutek Wilk
2012-05-31 20:21 ` H. Peter Anvin [this message]
2012-05-31 20:35 ` Konrad Rzeszutek Wilk
2012-05-31 23:02 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FC7D2AE.9080603@zytor.com \
--to=hpa@zytor.com \
--cc=konrad.wilk@oracle.com \
--cc=konrad@darnok.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=stable@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox