From: Daniel Santos <danielfsantos@att.net>
To: linux-kernel@vger.kernel.org
Cc: Kent Overstreet <koverstreet@google.com>,
tj@kernel.org, Peter Zijlstra <peterz@infradead.org>,
axboe@kernel.dk, paul.gortmaker@windriver.com,
Andi Kleen <andi@firstfloor.org>
Subject: Re: [PATCH v2 1/3] [RFC] Generic Red-Black Trees
Date: Thu, 31 May 2012 20:08:33 -0500 [thread overview]
Message-ID: <4FC81611.9090801@att.net> (raw)
In-Reply-To: <4FC7FD23.6080800@att.net>
Oh yeah, so the patch set I sent boots & runs fine. I've also noticed
that I have a few outdated doc-comments and a mistake in the
doc-comments for
the BUILD_BUG_ON_NON_CONST2() macro, under the "Normal Variables"
section, the text "global non-static const broken until 4.2 (-O1 broken
until 4.4)" contradicts the earlier statement that all const values
should never fail. This only applies to floats (but not doubles), which
we don't have to worry about in the kernel anyway. (incidentally, their
behavior under __builtin_constant_p() varies quite a bit until gcc 4.4,
where it's fine)
It was important for me to figure out what was and wasn't working with
__builtin_constant_p(), and in what versions of gcc because this
implementation relies heavily on the compiler optimizing out code based
upon values pass to it via a const struct pointer. Also, I was looking
for other possibilities, as I continued discovered broken (improperly
optimized) scenarios.
Daniel
next prev parent reply other threads:[~2012-06-01 1:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-31 23:22 [PATCH v2 1/3] [RFC] Generic Red-Black Trees Daniel Santos
2012-05-31 23:26 ` [PATCH v2 2/3] " Daniel Santos
2012-05-31 23:30 ` [PATCH v2 3/3] " Daniel Santos
2012-06-01 1:08 ` Daniel Santos [this message]
2012-06-01 17:56 ` [PATCH v2 1/3] [RFC] Generic Red-Black Trees (performance notes) Daniel Santos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FC81611.9090801@att.net \
--to=danielfsantos@att.net \
--cc=andi@firstfloor.org \
--cc=axboe@kernel.dk \
--cc=daniel.santos@pobox.com \
--cc=koverstreet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=peterz@infradead.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox