From: KOSAKI Motohiro <kosaki.motohiro@gmail.com>
To: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
Cc: KOSAKI Motohiro <kosaki.motohiro@gmail.com>,
hpa@zytor.com, mingo@redhat.com, tglx@linutronix.de,
x86@kernel.org, linux-kernel@vger.kernel.org,
rientjes@google.com
Subject: Re: [Patch] x86 : set numa_nodes_parsed at acpi_numa_memory_affinity_init
Date: Fri, 01 Jun 2012 13:09:20 -0400 [thread overview]
Message-ID: <4FC8F740.7070606@gmail.com> (raw)
In-Reply-To: <4FC8A2AA.5090003@jp.fujitsu.com>
(6/1/12 7:08 AM), Yasuaki Ishimatsu wrote:
> Hi Kosaki-san,
>
> 2012/05/31 20:25, KOSAKI Motohiro wrote:
>> Hi Ishimatsu-san,
>>
>>
>> (5/29/12 3:45 AM), Yasuaki Ishimatsu wrote:
>>> When hot-adding a CPU into my system, the system showed following message
>>> since node_to_cpumask_map[2] was not allocated memory.
>>>
>>> Booting Node 2 Processor 32 APIC 0xc0
>>> node_to_cpumask_map[2] NULL
>>> Pid: 0, comm: swapper/32 Tainted: G A 3.3.5-acd #21
>>> Call Trace:
>>> [<ffffffff81048845>] debug_cpumask_set_cpu+0x155/0x160
>>> [<ffffffff8105e28a>] ? add_timer_on+0xaa/0x120
>>> [<ffffffff8150665f>] numa_add_cpu+0x1e/0x22
>>> [<ffffffff815020bb>] identify_cpu+0x1df/0x1e4
>>> [<ffffffff815020d6>] identify_econdary_cpu+0x16/0x1d
>>> [<ffffffff81504614>] smp_store_cpu_info+0x3c/0x3e
>>> [<ffffffff81505263>] smp_callin+0x139/0x1be
>>> [<ffffffff815052fb>] start_secondary+0x13/0xeb
>>>
>>> In my investigation, the root cause is that the bit of node 2 was not set at
>>> numa_nodes_parsed since hot-added cpu was not written in ACPI SRAT Table.
>>> But hot-added memory which is same PXM as the cpu is written in here.
>>
>> I don't understand this explanation. If cpu is not written in srat table,
>> it is firmware bug. isn't it? srat table should describe all possible cpus.
>> Why doesn't your system describe cpu info in acpi table?
>
> As jiang answered, hot-added CPU need not be written in SRAT Table.
> So I don't think it is firmware bug.
If so, please write it to the description. Your changelog was unclear. Other than that,
Acked-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
next prev parent reply other threads:[~2012-06-01 17:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-29 7:45 [Patch] x86 : set numa_nodes_parsed at acpi_numa_memory_affinity_init Yasuaki Ishimatsu
2012-05-31 11:25 ` KOSAKI Motohiro
2012-05-31 12:39 ` Jiang Liu
2012-06-01 11:08 ` Yasuaki Ishimatsu
2012-06-01 17:09 ` KOSAKI Motohiro [this message]
2012-05-31 20:37 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FC8F740.7070606@gmail.com \
--to=kosaki.motohiro@gmail.com \
--cc=hpa@zytor.com \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rientjes@google.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox