From: Daniel Santos <danielfsantos@att.net>
To: linux-kernel@vger.kernel.org
Cc: Kent Overstreet <koverstreet@google.com>,
tj@kernel.org, Peter Zijlstra <peterz@infradead.org>,
axboe@kernel.dk, paul.gortmaker@windriver.com,
Andi Kleen <andi@firstfloor.org>
Subject: Re: [PATCH v2 1/3] [RFC] Generic Red-Black Trees (performance notes)
Date: Fri, 01 Jun 2012 12:56:55 -0500 [thread overview]
Message-ID: <4FC90267.7050102@att.net> (raw)
In-Reply-To: <4FC81611.9090801@att.net>
I've done a bit more analysis of the generated code of
kernel/sched/fair.c (patched) under three versions of gcc.
gcc-4.5.3
* 48 bytes larger
* one instance of a (const_flag & ENUM_VALUE) fails to compile out
* compare function not inlined
gcc-4.6.2
* same size
* ANDed constants compiled out
* compare function inlined
gcc-4.7.0:
* 64 bytes smaller - __enqueue_entity() reduced by 16 bytes (2 byte
smaller and saved some padding, so essentially the same), I'm not sure
where the other 48 bytes came from, I'm guessing just alignment changes
from using different registers (smaller opcodes).
So in summary, the results on 4.5 are worse, but not "horrible". The
problems are fixed in 4.6 and later.
There's still lots of other scenarios to test.
Daniel
prev parent reply other threads:[~2012-06-01 18:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-31 23:22 [PATCH v2 1/3] [RFC] Generic Red-Black Trees Daniel Santos
2012-05-31 23:26 ` [PATCH v2 2/3] " Daniel Santos
2012-05-31 23:30 ` [PATCH v2 3/3] " Daniel Santos
2012-06-01 1:08 ` [PATCH v2 1/3] " Daniel Santos
2012-06-01 17:56 ` Daniel Santos [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FC90267.7050102@att.net \
--to=danielfsantos@att.net \
--cc=andi@firstfloor.org \
--cc=axboe@kernel.dk \
--cc=daniel.santos@pobox.com \
--cc=koverstreet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=peterz@infradead.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox