From: Larry Finger <Larry.Finger@lwfinger.net>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Question about do_mmap changes
Date: Mon, 04 Jun 2012 00:29:45 -0500 [thread overview]
Message-ID: <4FCC47C9.8050904@lwfinger.net> (raw)
Al,
In commit e3fc629d7bb70848fbf479688a66d4e76dff46ac in 3.5-rc1, you change
do_mmap() to static, and use do_mmap_pgoff() instaed. The VirtualBox kernel
module calls do_mmap(), and no longer compiles. I fixed the compile problem with
the patch
Index: vboxhost/vboxdrv/r0drv/linux/memobj-r0drv-linux.c
===================================================================
--- vboxhost.orig/vboxdrv/r0drv/linux/memobj-r0drv-linux.c
+++ vboxhost/vboxdrv/r0drv/linux/memobj-r0drv-linux.c
@@ -65,6 +65,13 @@
# define VBOX_USE_PAE_HACK
#endif
+/*
+ * 3.5+ kernels no longer have do_mmap(). They need to call
+ * do_mmap_pgoff() instead.
+ */
+#if LINUX_VERSION_CODE >= KERNEL_VERSION(3, 5, 0)
+#define do_mmap do_mmap_pgoff
+#endif
/*******************************************************************************
* Structures and Typedefs
================================
Although the code now compiles OK, the link step results in
WARNING: "do_mmap_pgoff" [/usr/share/virtualbox/src/vboxhost/vboxdrv/vboxdrv.ko]
undefined!
WARNING: "do_munmap" [/usr/share/virtualbox/src/vboxhost/vboxdrv/vboxdrv.ko]
undefined!
================================
I am not quite sure why do_munmap() is undefined as the symbol is exported;
however, should do_mmap_pgoff() be exported?
Thanks,
Larry
next reply other threads:[~2012-06-04 5:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-04 5:29 Larry Finger [this message]
2012-06-04 6:26 ` Question about do_mmap changes Al Viro
2012-06-04 6:37 ` Larry Finger
2012-06-04 6:56 ` Al Viro
2012-06-04 7:27 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FCC47C9.8050904@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox