From: Jens Axboe <axboe@kernel.dk>
To: Tejun Heo <tj@kernel.org>
Cc: linux-kernel@vger.kernel.org, Vivek Goyal <vgoyal@redhat.com>
Subject: Re: [PATCH v3.5-rc1] blkcg: fix blkg_alloc() failure path
Date: Mon, 04 Jun 2012 15:23:48 +0200 [thread overview]
Message-ID: <4FCCB6E4.7020708@kernel.dk> (raw)
In-Reply-To: <20120604062100.GA2843@dhcp-172-17-108-109.mtv.corp.google.com>
On 06/04/2012 08:21 AM, Tejun Heo wrote:
> When policy data allocation fails in the middle, blkg_alloc() invokes
> blkg_free() to destroy the half constructed blkg. This ends up
> calling pd_exit_fn() on policy datas which didn't go through
> pd_init_fn(). Fix it by making blkg_alloc() call pd_init_fn()
> immediately after each policy data allocation.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Acked-by: Vivek Goyal <vgoyal@redhat.com>
> ---
> Jens, this was posted as part of "block: implement per-blkg request
> allocation" patchset[1] but should be applied as fix on v3.5-rc1.
Applied for 3.5 current, thanks.
--
Jens Axboe
prev parent reply other threads:[~2012-06-04 13:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-04 6:21 [PATCH v3.5-rc1] blkcg: fix blkg_alloc() failure path Tejun Heo
2012-06-04 13:23 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FCCB6E4.7020708@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox