From: Richard Weinberger <richard@nod.at>
To: Boaz Harrosh <bharrosh@panasas.com>
Cc: Jiri Slaby <jslaby@suse.cz>, Jiri Slaby <jirislaby@gmail.com>,
user-mode-linux-devel@lists.sourceforge.net,
gregkh@linuxfoundation.org, Jeff Dike <jdike@addtoit.com>,
linux-kernel@vger.kernel.org, Al Viro <viro@zeniv.linux.org.uk>,
alan@linux.intel.com
Subject: Re: [uml-devel] [PATCH 13/24] TTY: um/line, use tty from tty_port
Date: Mon, 04 Jun 2012 18:29:09 +0200 [thread overview]
Message-ID: <4FCCE255.4080705@nod.at> (raw)
In-Reply-To: <4FCCE1D4.7080805@panasas.com>
[-- Attachment #1: Type: text/plain, Size: 868 bytes --]
Am 04.06.2012 18:27, schrieb Boaz Harrosh:
> On 06/04/2012 06:42 PM, Richard Weinberger wrote:
>
>> Am 04.06.2012 17:41, schrieb Jiri Slaby:
>>> Hmm, I remember. I suggest you to split the patch into several pieces.
>>> For example moving the code from ->open into ->install can be done
>>> separately. Otherwise it's hard to tell what's wrong with the patch as
>>> a whole.
>>>
>>> Also, it would be good to see the patch rebased on the top of my
>>> patch, because tty_port_set/get pieces would be gone from your patch too.
>>
>> Okay, I'll redo it!
>> I've a much cleaner version in my local queue.
>>
>
>
> Can you send it my way, I'm still running broken, 3.4 Based ?
>
Can you please first give Jiri's patches a try?
[PATCH 12/24] TTY: um/line, add tty_port
[PATCH 13/24] TTY: um/line, use tty from tty_port
Thanks,
//richard
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
next prev parent reply other threads:[~2012-06-04 16:29 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-04 11:35 [PATCH 00/25] TTY buffer in tty_port -- prep no. 3 Jiri Slaby
2012-06-04 11:35 ` [PATCH 01/24] TTY: cyclades, add local pointer for card Jiri Slaby
2012-06-04 11:35 ` [PATCH 02/24] TTY: ircomm, add tty_port Jiri Slaby
2012-06-04 11:35 ` [PATCH 03/24] TTY: ircomm, use close times from tty_port Jiri Slaby
2012-06-04 11:35 ` [PATCH 04/24] TTY: ircomm, use open counts " Jiri Slaby
2012-06-04 16:36 ` Alan Cox
2012-06-04 11:35 ` [PATCH 05/24] TTY: ircomm, use flags " Jiri Slaby
2012-06-04 11:35 ` [PATCH 06/24] TTY: ircomm, revamp locking Jiri Slaby
2012-06-04 16:57 ` Alan Cox
2012-06-04 11:35 ` [PATCH 07/24] TTY: ircomm, use tty from tty_port Jiri Slaby
2012-06-04 11:35 ` [PATCH 08/24] TTY: ircomm, define local tty_port Jiri Slaby
2012-06-04 11:35 ` [PATCH 09/24] TTY: ircomm, define carrier routines Jiri Slaby
2012-06-04 11:35 ` [PATCH 10/24] TTY: ircomm, use tty_port_close_end helper Jiri Slaby
2012-06-04 11:35 ` [PATCH 11/24] TTY: ircomm, use tty_port_close_start helper Jiri Slaby
2012-06-04 11:35 ` [PATCH 12/24] TTY: um/line, add tty_port Jiri Slaby
2012-06-04 11:35 ` [PATCH 13/24] TTY: um/line, use tty from tty_port Jiri Slaby
2012-06-04 12:01 ` Richard Weinberger
2012-06-04 15:20 ` Jiri Slaby
2012-06-04 15:29 ` Richard Weinberger
2012-06-04 15:41 ` Jiri Slaby
2012-06-04 15:42 ` Richard Weinberger
2012-06-04 16:27 ` [uml-devel] " Boaz Harrosh
2012-06-04 16:29 ` Richard Weinberger [this message]
2012-06-04 16:37 ` Boaz Harrosh
2012-06-04 16:55 ` Boaz Harrosh
2012-06-04 17:05 ` Richard Weinberger
2012-06-04 17:14 ` Boaz Harrosh
2012-06-04 15:58 ` Alan Cox
2012-06-04 11:35 ` [PATCH 14/24] PTY: remove one empty ops->remove Jiri Slaby
2012-06-04 11:35 ` [PATCH 15/24] PTY: merge pty_install implementations Jiri Slaby
2012-06-04 11:35 ` [PATCH 16/24] PTY: add tty_port Jiri Slaby
2012-06-12 22:55 ` Greg KH
2012-06-14 0:29 ` Greg KH
2012-06-14 0:31 ` Greg KH
2012-06-04 11:35 ` [PATCH 17/24] TTY: vt, remove con_schedule_flip Jiri Slaby
2012-06-04 11:35 ` [PATCH 18/24] TTY: provide drivers with tty_port_install Jiri Slaby
2012-06-04 11:35 ` [PATCH 19/24] TTY: vt, add ->install Jiri Slaby
2012-06-04 11:35 ` [PATCH 20/24] TTY: usb-serial, use tty_port_install Jiri Slaby
2012-06-04 11:35 ` [PATCH 21/24] TTY: centralize fail paths in tty_register_driver Jiri Slaby
2012-06-04 11:35 ` [PATCH 22/24] TTY: add ports array to tty_driver Jiri Slaby
2012-06-04 11:35 ` [PATCH 23/24] TTY: add tty_port_register_device helper Jiri Slaby
2012-06-04 11:35 ` [PATCH 24/24] TTY: use tty_port_register_device Jiri Slaby
2012-06-04 17:00 ` Alan Cox
2012-06-09 14:58 ` Jiri Slaby
2012-06-09 17:27 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FCCE255.4080705@nod.at \
--to=richard@nod.at \
--cc=alan@linux.intel.com \
--cc=bharrosh@panasas.com \
--cc=gregkh@linuxfoundation.org \
--cc=jdike@addtoit.com \
--cc=jirislaby@gmail.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=user-mode-linux-devel@lists.sourceforge.net \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox