From: Jiri Slaby <jslaby@suse.cz>
To: Richard Weinberger <richard@nod.at>
Cc: user-mode-linux-devel@lists.sourceforge.net,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
viro@zeniv.linux.org.uk, alan@linux.intel.com
Subject: Re: [PATCH 5/6] um: fully use tty_port
Date: Mon, 04 Jun 2012 22:47:53 +0200 [thread overview]
Message-ID: <4FCD1EF9.6000001@suse.cz> (raw)
In-Reply-To: <1338841657-30358-6-git-send-email-richard@nod.at>
On 06/04/2012 10:27 PM, Richard Weinberger wrote:
> +void line_cleanup(struct tty_struct *tty)
> +{
> + struct line *line = tty->driver_data;
>
> if (line->sigio) {
> unregister_winch(tty);
> line->sigio = 0;
r u sure you want to to do this asynchronously? This should be
tty_port_operations->shutdown I suppose...
> }
> +}
Anyway, please split the patch into 2 pieces at least:
1) introducing ->install and moving the setup there.
2) switching to tty port helpers
Otherwise it's a hard-to-review mess.
thanks,
--
js
suse labs
next prev parent reply other threads:[~2012-06-04 20:48 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-04 20:27 um: TTY fixes (?) Richard Weinberger
2012-06-04 20:27 ` [PATCH 1/6] TTY: um/line, add tty_port Richard Weinberger
2012-06-04 20:27 ` [PATCH 2/6] TTY: um/line, use tty from tty_port Richard Weinberger
2012-06-04 20:27 ` [PATCH 3/6] um: remove line_ioctl() Richard Weinberger
2012-06-04 20:27 ` [PATCH 4/6] um: Remove dead code Richard Weinberger
2012-06-04 20:27 ` [PATCH 5/6] um: fully use tty_port Richard Weinberger
2012-06-04 20:47 ` Jiri Slaby [this message]
2012-06-04 20:27 ` [PATCH 6/6] um: remove count_lock Richard Weinberger
2012-06-04 21:17 ` um: TTY fixes (?) Alan Cox
2012-06-04 23:14 ` Richard Weinberger
2012-06-05 10:41 ` Karel Zak
2012-06-05 11:15 ` Alan Cox
2012-06-05 12:20 ` Richard Weinberger
2012-06-05 15:17 ` Karel Zak
2012-07-12 14:49 ` Karel Zak
2012-07-12 15:01 ` Richard Weinberger
2012-06-06 23:17 ` Richard Weinberger
2012-06-07 9:19 ` Alan Cox
2012-06-07 9:06 ` Richard Weinberger
2012-06-06 14:20 ` [uml-devel] " Boaz Harrosh
2012-06-07 7:35 ` Boaz Harrosh
2012-06-07 7:43 ` Boaz Harrosh
2012-06-07 8:45 ` Richard Weinberger
2012-06-07 9:22 ` Alan Cox
2012-06-07 10:14 ` Boaz Harrosh
2012-06-07 10:19 ` Richard Weinberger
2012-06-07 10:35 ` Boaz Harrosh
2012-06-07 10:52 ` Alan Cox
2012-06-07 13:41 ` Boaz Harrosh
2012-06-07 15:18 ` Richard Weinberger
2012-06-07 16:37 ` Alan Cox
2012-06-07 16:32 ` Richard Weinberger
2012-06-07 16:50 ` Alan Cox
2012-06-07 16:41 ` Richard Weinberger
2012-06-07 17:26 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FCD1EF9.6000001@suse.cz \
--to=jslaby@suse.cz \
--cc=alan@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=richard@nod.at \
--cc=user-mode-linux-devel@lists.sourceforge.net \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox