From: Jens Axboe <axboe@kernel.dk>
To: Asai Thambi S P <asamymuthupa@micron.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Greg KH <gregkh@linuxfoundation.org>,
Sam Bradshaw <sbradshaw@micron.com>
Subject: Re: [PATCH 2/2] mtip32xx: Create debugfs entries for troubleshooting
Date: Tue, 05 Jun 2012 09:17:51 +0200 [thread overview]
Message-ID: <4FCDB29F.8060107@kernel.dk> (raw)
In-Reply-To: <4FCD1002.2060203@micron.com>
On 06/04/2012 09:44 PM, Asai Thambi S P wrote:
> @@ -4062,10 +4210,20 @@ static int __init mtip_init(void)
> }
> mtip_major = error;
>
> + if (!dfs_parent) {
> + dfs_parent = debugfs_create_dir("rssd", NULL);
> + if (IS_ERR_OR_NULL(dfs_parent)) {
> + printk(KERN_WARNING "Error creating debugfs parent\n");
> + dfs_parent = NULL;
> + }
> + }
> +
Why would dfs_parent ever be non-NULL here?
Apart from that, looks fine.
--
Jens Axboe
next prev parent reply other threads:[~2012-06-05 7:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-04 19:44 [PATCH 2/2] mtip32xx: Create debugfs entries for troubleshooting Asai Thambi S P
2012-06-05 7:17 ` Jens Axboe [this message]
2012-06-05 18:03 ` Asai Thambi S P
2012-06-05 18:11 ` Asai Thambi S P
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FCDB29F.8060107@kernel.dk \
--to=axboe@kernel.dk \
--cc=asamymuthupa@micron.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sbradshaw@micron.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox