public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: YOSHIDA Masanori <masanori.yoshida.tv@hitachi.com>
To: Vivek Goyal <vgoyal@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	x86@kernel.org, linux-kernel@vger.kernel.org,
	Andy Lutomirski <luto@mit.edu>, Ingo Molnar <mingo@elte.hu>,
	KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
	Kees Cook <keescook@chromium.org>, Kevin Hilman <khilman@ti.com>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Prarit Bhargava <prarit@redhat.com>,
	"Rafael J. Wysocki" <rjw@sisk.pl>, Tejun Heo <tj@kernel.org>,
	yrl.pp-manager.tt@hitachi.com
Subject: Re: [RFC PATCH 0/4 V2] introduce: livedump
Date: Tue, 05 Jun 2012 18:50:19 +0900	[thread overview]
Message-ID: <4FCDD65B.6090402@hitachi.com> (raw)
In-Reply-To: <20120604210912.GA18354@redhat.com>

Hi, Vivek and Peter

Thank you for your replies.

Yes, I agree that it is terrible to consume a half of memory only for
this purpose.

I think buffer size can be reduced by dumping memory to disk
on-the-fly with buffer of limited size.
However, this means that page fault(PF) handling may sleep if the
buffer is temporarily full.
It is never acceptable when PF happens in preempt_disable()ed path,
but I think size of pages updated in the path is not much.

To reduce buffer size, we can introduce two types of buffers as below;
(1)Buffer dedicated for non-preemptible path
(2)Buffer for the rest

If the first buffer is full, tracking updated pages partially fails.
To avoid this, users need to allocate enough memory for this buffer.

We don't need to care about the second buffer being full,
because PF handling can wait for space by sleeping.

Regards,
Masanori

Yokohama Research Laboratory,
Hitachi, Ltd.


On 2012/06/05 6:09, Vivek Goyal wrote:
> On Fri, May 25, 2012 at 06:12:07PM +0900, YOSHIDA Masanori wrote:
>
> [..]
>> (4) It allocates about 50% of physical RAM to store dumped pages. Currently
>>      Live Dump saves all dumped data on memory once, and after that a user
>>      becomes able to use the dumped data. Live Dump itself has no feature to
>>      save dumped data onto a disk or any other storage device.
>
> People complain when kdump reserves 128M of memory when system crashes.
> I am skeptical that reserving 50% of memory for livedumps is going to fly.
>
> Thanks
> Vivek


  reply	other threads:[~2012-06-05  9:50 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-25  9:12 [RFC PATCH 0/4 V2] introduce: livedump YOSHIDA Masanori
2012-05-25  9:12 ` [RFC PATCH 1/4 V2] livedump: Add notifier-call-chain into do_page_fault YOSHIDA Masanori
2012-05-25  9:19   ` Peter Zijlstra
2012-05-25 12:14     ` YOSHIDA Masanori
2012-05-25  9:12 ` [RFC PATCH 3/4 V2] livedump: Add write protection management YOSHIDA Masanori
2012-05-25  9:12 ` [RFC PATCH 2/4 V2] livedump: Add the new misc device "livedump" YOSHIDA Masanori
2012-05-25  9:12 ` [RFC PATCH 4/4 V2] livedump: Add memory dumping functionality YOSHIDA Masanori
2012-05-25  9:25 ` [RFC PATCH 0/4 V2] introduce: livedump Peter Zijlstra
2012-05-25 11:12   ` YOSHIDA Masanori
2012-06-04 21:09 ` Vivek Goyal
2012-06-05  9:50   ` YOSHIDA Masanori [this message]
2012-06-04 21:29 ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FCDD65B.6090402@hitachi.com \
    --to=masanori.yoshida.tv@hitachi.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=hpa@zytor.com \
    --cc=keescook@chromium.org \
    --cc=khilman@ti.com \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@mit.edu \
    --cc=mingo@elte.hu \
    --cc=mingo@redhat.com \
    --cc=prarit@redhat.com \
    --cc=rjw@sisk.pl \
    --cc=tglx@linutronix.de \
    --cc=tj@kernel.org \
    --cc=vgoyal@redhat.com \
    --cc=x86@kernel.org \
    --cc=yrl.pp-manager.tt@hitachi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox