public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Konstantin Khlebnikov <khlebnikov@openvz.org>
To: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Cc: "Ondrej Zary" <linux@rainbow-software.org>,
	"Hugh Dickins" <hughd@google.com>,
	"Kernel development list" <linux-kernel@vger.kernel.org>,
	"Dave Jones" <davej@redhat.com>,
	"Hans de Bruin" <jmdebruin@xmsnet.nl>,
	"Linux NFS mailing list" <linux-nfs@vger.kernel.org>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Toralf Förster" <toralf.foerster@gmx.de>,
	"richard -rw- weinberger" <richard.weinberger@gmail.com>
Subject: Re: [bisected commit 0fc9d10] NFS-server corruption with 3.4
Date: Tue, 05 Jun 2012 19:14:30 +0400	[thread overview]
Message-ID: <4FCE2256.7010804@openvz.org> (raw)
In-Reply-To: <87zk8h23wn.fsf@devron.myhome.or.jp>

OGAWA Hirofumi wrote:
> Konstantin Khlebnikov<khlebnikov@openvz.org>  writes:
>
>> Hmm, very interesting!
>> Please try this patch, it must fix the problem and print some numbers to debug.
>>
>
> I think the bug is in radix_tree_for_each_contig().
>
> radix_tree_next_slot() returns NULL if the slot was NULL (i.e. there is
> hole). But, slot == NULL is not meaning to stop iterate here. Actually,
> if slot is NULL, it gets next chunk.
>
> Bang.

Yeah, you are right, I already found this too.
Currently I think how to fix this more accurately...

  reply	other threads:[~2012-06-05 15:14 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-05  9:16 [bisected] NFS corruption with 3.4 Ondrej Zary
2012-06-05 12:45 ` Dave Jones
2012-06-05 13:45   ` Holger Hoffstaette
2012-06-05 14:11   ` Ondrej Zary
2012-06-05 13:32 ` [bisected commit 0fc9d10] NFS-server " Konstantin Khlebnikov
2012-06-05 14:20   ` Ondrej Zary
2012-06-05 14:52     ` Konstantin Khlebnikov
2012-06-05 15:07       ` OGAWA Hirofumi
2012-06-05 15:14         ` Konstantin Khlebnikov [this message]
2012-06-05 15:59           ` Konstantin Khlebnikov
2012-06-05 16:18             ` OGAWA Hirofumi
2012-06-05 16:39               ` Konstantin Khlebnikov
2012-06-05 22:30                 ` Hans de Bruin
2012-06-06 10:54                   ` Konstantin Khlebnikov
2012-06-05 17:03             ` Toralf Förster
2012-06-05 17:17               ` Konstantin Khlebnikov
2012-06-06  8:55             ` Ondrej Zary
2012-06-05 14:21   ` Toralf Förster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FCE2256.7010804@openvz.org \
    --to=khlebnikov@openvz.org \
    --cc=akpm@linux-foundation.org \
    --cc=davej@redhat.com \
    --cc=hirofumi@mail.parknet.co.jp \
    --cc=hughd@google.com \
    --cc=jmdebruin@xmsnet.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=linux@rainbow-software.org \
    --cc=richard.weinberger@gmail.com \
    --cc=toralf.foerster@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox