From: David Ahern <dsahern@gmail.com>
To: Roland Dreier <roland@purestorage.com>
Cc: Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Stephane Eranian <eranian@google.com>,
LKML <linux-kernel@vger.kernel.org>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Subject: Re: git bisect and perf
Date: Tue, 05 Jun 2012 10:56:54 -0600 [thread overview]
Message-ID: <4FCE3A56.9060400@gmail.com> (raw)
In-Reply-To: <CAL1RGDWjA8uh3924s4+F=zD3EJpUXk6auJpi=zPWJRE4sY8FCw@mail.gmail.com>
On 6/5/12 9:51 AM, Roland Dreier wrote:
> On Tue, Jun 5, 2012 at 8:29 AM, David Ahern<dsahern@gmail.com> wrote:
>> # git bisect good v2.6.38
>> Some good revs are not ancestor of the bad rev.
>> git bisect cannot work properly in this case.
>> Maybe you mistake good and bad revs?
>
> git bisect is telling you what is wrong -- as the man page says:
>
> This command uses git rev-list --bisect to help drive the binary
> search process to find which change introduced a bug, given an old
> "good" commit object name and a later "bad" commit object name.
>
> so it assumes the good commit is older than the bad commit.
>
> You can actually use git bisect in your case, although it gets very confusing
> unless you write yourself a little wrapper alias: just swap the meaning of
> good and bad, ie do
>
> # git bisect start arch/x86/kernel/cpu/perf_event*
> # git bisect good v2.6.35
> # git bisect bad v2.6.38
>
> and try somehow to remember that when you do a test, "bad" means
> PEBS works and "good" means PEBS doesn't work.
>
> - R.
Thanks, Roland. I'll reverse the logic.
David
next prev parent reply other threads:[~2012-06-05 16:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-05 15:29 git bisect and perf David Ahern
2012-06-05 15:51 ` Roland Dreier
2012-06-05 16:56 ` David Ahern [this message]
2012-06-05 16:00 ` Peter Zijlstra
2012-06-05 16:05 ` Peter Zijlstra
2012-06-05 17:12 ` David Ahern
2012-06-05 17:35 ` Peter Zijlstra
2012-06-05 23:48 ` David Ahern
2012-06-06 11:46 ` Stephane Eranian
2012-06-05 19:04 ` Stephane Eranian
2012-06-05 19:08 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FCE3A56.9060400@gmail.com \
--to=dsahern@gmail.com \
--cc=acme@ghostprotocols.net \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=roland@purestorage.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox