Re: [PATCH 2/2] mtip32xx: Create debugfs entries for troubleshooting

[Asai Thambi S P <asamymuthupa@micron.com>]

On 6/5/2012 11:03 AM, Asai Thambi S P wrote:

> On 6/5/2012 12:17 AM, Jens Axboe wrote:
> 
>> On 06/04/2012 09:44 PM, Asai Thambi S P wrote:
>>> @@ -4062,10 +4210,20 @@ static int __init mtip_init(void)
>>>  	}
>>>  	mtip_major = error;
>>>  
>>> +	if (!dfs_parent) {
>>> +		dfs_parent = debugfs_create_dir("rssd", NULL);
>>> +		if (IS_ERR_OR_NULL(dfs_parent)) {
>>> +			printk(KERN_WARNING "Error creating debugfs parent\n");
>>> +			dfs_parent = NULL;
>>> +		}
>>> +	}
>>> +
>>
>> Why would dfs_parent ever be non-NULL here?
>>
>> Apart from that, looks fine.
>>
> 
> I moved this part from mtip_hw_debugfs_init(), dfs_parent will not be NULL here.
> 


dfs_parent will be NULL here :)

--
Regards,
Asai Thambi