Re: [V2 RFC net-next PATCH 2/2] virtio_net: export more statistics through ethtool

Rick Jones
2012-06-07T20:39:52Z

On 06/07/2012 01:24 PM, Ben Hutchings wrote:
> On Thu, 2012-06-07 at 13:05 -0700, David Miller wrote:
>> From: Ben Hutchings<bhutchings@solarflare.com>
>> Date: Thu, 7 Jun 2012 18:15:06 +0100
>>
>>> I would really like to see some sort of convention for presenting
>>> per-queue statistics through ethtool. At the moment we have a complete
>>> mess of different formats:
>>
>> Indeed. Probably ${QUEUE_TYPE}-${INDEX}-${STATISTIC} is best.
>> With an agreed upon list of queue types such as "rx", "tx", "rxtx"
>> etc.
>
> I think we should leave the type names open-ended, as there are other
> useful groupings like per-virtual-port. In that case the separator
> should be chosen to allow arbitrary type names without ambiguity.

So you mean like something along the lines of the presence of say '.'
indicating indent a level:

rx_bytes: 1234
myqueue1.rx_bytes: 234
myqueue2.rx_bytes: 345
...

rick jones