Re: [PATCH] pstore/ram: Add ramoops support for the Flattened Device Tree.

[Stephen Boyd <sboyd@codeaurora.org>]

On 06/05/12 12:59, Bryan Freed wrote:
> When called with a non-zero of_node, fill out a new ramoops_platform_data
> with data from the specified Flattened Device Tree node.
> Update ramoops documentation with the new FDT interface.
>
> Change-Id: Id8f9f0abc5b564375c1b6d5d30c92d57d76520b7
> Signed-off-by: Bryan Freed <bfreed@chromium.org>
> ---
>  Documentation/ramoops.txt |   19 +++++++++++++++++--
>  fs/pstore/ram.c           |   43 +++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 60 insertions(+), 2 deletions(-)

Can you document the binding in Documentation/devicetree/bindings/* too?

> diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c
> index 9123cce..bf0f882 100644
> --- a/fs/pstore/ram.c
> +++ b/fs/pstore/ram.c
> @@ -213,6 +248,14 @@ static int __init ramoops_probe(struct platform_device *pdev)
>  	if (cxt->max_count)
>  		goto fail_out;
>  
> +	if (pdev->dev.of_node) {
> +		if (of_ramoops_platform_data(pdev->dev.of_node, &of_pdata)) {
> +			pr_err("Invalid ramoops device tree data\n");

dev_err()?

-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.