From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Felipe Balbi <balbi@ti.com>,
kernel-janitors@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
joe@perches.com, Julia Lawall <julia@diku.dk>
Subject: Re: [PATCH 3/7] drivers/usb/gadget/pch_udc.c: adjust suspicious bit operation
Date: Thu, 07 Jun 2012 17:00:41 +0400 [thread overview]
Message-ID: <4FD0A5F9.9050405@mvista.com> (raw)
In-Reply-To: <1339018901-28439-4-git-send-email-Julia.Lawall@lip6.fr>
Hello.
On 07-06-2012 1:41, Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
> PCH_UDC_DMA_LAST is 0x08000000 so a bit-or with this value always gives a
> nonzero result. The test is rewritten as done elsewhere in the same file.
> This problem was found using Coccinelle (http://coccinelle.lip6.fr/).
> Signed-off-by: Julia Lawall<julia@diku.dk>
> ---
> drivers/usb/gadget/pch_udc.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/gadget/pch_udc.c b/drivers/usb/gadget/pch_udc.c
> index 1cfcc9e..79f7a53 100644
> --- a/drivers/usb/gadget/pch_udc.c
> +++ b/drivers/usb/gadget/pch_udc.c
> @@ -2208,7 +2208,8 @@ static void pch_udc_complete_receiver(struct pch_udc_ep *ep)
> return;
> }
> if ((td->status& PCH_UDC_BUFF_STS) == PCH_UDC_BS_DMA_DONE)
> - if (td->status | PCH_UDC_DMA_LAST) {
> + if ((td_data->status& PCH_UDC_DMA_LAST)
> + == PCH_UDC_DMA_LAST) {
But why not simply:
if (td_data->status & PCH_UDC_DMA_LAST)
if the constant is single bit anyway? And are you sure about s/td/td_data/?
WBR, Sergei
next prev parent reply other threads:[~2012-06-07 13:01 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-06 21:41 [PATCH 0/7] adjust suspicious bit operation Julia Lawall
2012-06-06 21:41 ` [PATCH 1/7] drivers/ide/ide-cs.c: " Julia Lawall
2012-06-07 21:46 ` David Miller
2012-06-07 21:59 ` Joe Perches
2012-06-08 5:12 ` Julia Lawall
2012-06-08 5:14 ` Julia Lawall
2012-06-11 23:43 ` David Miller
2012-06-12 14:17 ` Julia Lawall
2012-06-12 22:52 ` David Miller
2012-06-06 21:41 ` [PATCH 2/7] drivers/staging/comedi/drivers/me4000.c: " Julia Lawall
2012-06-06 21:41 ` [PATCH 3/7] drivers/usb/gadget/pch_udc.c: " Julia Lawall
2012-06-07 13:00 ` Sergei Shtylyov [this message]
2012-06-07 14:23 ` Julia Lawall
2012-06-07 15:05 ` Joe Perches
2012-06-08 12:58 ` Dan Carpenter
2012-06-08 15:28 ` Joe Perches
2012-06-06 21:41 ` [PATCH 4/7] fs/direct-io.c: " Julia Lawall
2012-06-07 14:24 ` Jeff Moyer
2012-06-06 21:41 ` [PATCH 5/7] drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c: " Julia Lawall
2012-06-06 23:43 ` Franky Lin
2012-06-06 21:41 ` [PATCH 6/7] drivers/ata/pata_pcmcia.c: " Julia Lawall
2012-06-06 21:41 ` [PATCH 7/7] drivers/net/can/cc770/cc770_platform.c: " Julia Lawall
2012-06-06 21:52 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FD0A5F9.9050405@mvista.com \
--to=sshtylyov@mvista.com \
--cc=Julia.Lawall@lip6.fr \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox