public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Maarten Lankhorst <m.b.lankhorst@gmail.com>
To: lee.g.rosenbaum@intel.com, mingo@kernel.org, hpa@zytor.com,
	linux-kernel@vger.kernel.org, jordan.l.justen@intel.com,
	tglx@linutronix.de, rydberg@euromail.se, matt.fleming@intel.com
Cc: linux-tip-commits@vger.kernel.org
Subject: Re: [tip:x86/urgent] x86, efi stub: Add .reloc section back into image
Date: Thu, 07 Jun 2012 22:20:12 +0200	[thread overview]
Message-ID: <4FD10CFC.8030000@gmail.com> (raw)
In-Reply-To: <tip-743628e868c5992354fc80b4d1e9a6143da1c0e6@git.kernel.org>

Hey,

Op 07-06-12 20:37, tip-bot for Jordan Justen schreef:
> Commit-ID:  743628e868c5992354fc80b4d1e9a6143da1c0e6
> Gitweb:     http://git.kernel.org/tip/743628e868c5992354fc80b4d1e9a6143da1c0e6
> Author:     Jordan Justen <jordan.l.justen@intel.com>
> AuthorDate: Thu, 7 Jun 2012 09:05:21 -0700
> Committer:  H. Peter Anvin <hpa@zytor.com>
> CommitDate: Thu, 7 Jun 2012 09:52:33 -0700
>
> x86, efi stub: Add .reloc section back into image
>
> Some UEFI firmware will not load a .efi with a .reloc section
> with a size of 0.
>
> Therefore, we create a .efi image with 4 main areas and 3 sections.
> 1. PE/COFF file header
> 2. .setup section (covers all setup code following the first sector)
> 3. .reloc section (contains 1 dummy reloc entry, created in build.c)
> 4. .text section (covers the remaining kernel image)
>
Scary how some patches arrive a few minutes before you need them.
I can verify applying this patch fixes efi stub booting for my system.
I wasn't even aware it was broken, but it definitely didn't want to boot
without. :-)

~Maarten

  reply	other threads:[~2012-06-07 20:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1339085121-12760-1-git-send-email-jordan.l.justen@intel.com>
2012-06-07 18:37 ` [tip:x86/urgent] x86, efi stub: Add .reloc section back into image tip-bot for Jordan Justen
2012-06-07 20:20   ` Maarten Lankhorst [this message]
2012-06-08  9:06     ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FD10CFC.8030000@gmail.com \
    --to=m.b.lankhorst@gmail.com \
    --cc=hpa@zytor.com \
    --cc=jordan.l.justen@intel.com \
    --cc=lee.g.rosenbaum@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=matt.fleming@intel.com \
    --cc=mingo@kernel.org \
    --cc=rydberg@euromail.se \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox