From: Greg Ungerer <gerg@snapgear.com>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
<linux-m68k@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] m68k: remove six unused headers
Date: Fri, 8 Jun 2012 16:26:49 +1000 [thread overview]
Message-ID: <4FD19B29.4050904@snapgear.com> (raw)
In-Reply-To: <1339059427.25798.3.camel@x61.thuisdomein>
Hi Paul,
On 07/06/12 18:57, Paul Bolle wrote:
> There are six entirely unused headers in arch/m68k/include/asm. Nothing
> includes these headers. And a few tests found no hits for the things
> they provide (which makes sense).
>
> MC68332.h, mac_mouse.h, mcfmbus.h, and mcfne.h are all unused since at
> least v2.6.12-rc2 (I didn't bother looking further back than that).
Although mcfne.h has been unused for a while I am working on some patches
that do use it. No problem for the others.
> apollodma.h is unused since v2.6.19: commit
> 2ed0ce5b57950a620155433c62a5a02a067f1376 ("m68k/Apollo: Remove obsolete
> arch/m68k/apollo/dma.c") removed the last file interested in that
> header.
>
> And everything interested in<asm/sbus.h> was removed in the v2.6.28
> release cycle. The last occurrence of "sbus.h" was deleted with commit
> 0c0db98b50ed1217c0dbf4051722034ba314d06e ("sparc: Remove
> Documentation/sparc/sbus_drivers.txt"). I'm not sure whether anything
> relevant for m68k was included in v2.6.27, but it doesn't really matter.
>
> Signed-off-by: Paul Bolle<pebolle@tiscali.nl>
Acked-by: Greg Ungerer<gerg@uclinux.org>
Regards
Greg
> ---
> Tested with "git grep" only. I haven't got the hardware nor the
> toolchain needed to do anything more thorough.
>
> arch/m68k/include/asm/MC68332.h | 152 -----------------------
> arch/m68k/include/asm/apollodma.h | 248 -------------------------------------
> arch/m68k/include/asm/mac_mouse.h | 23 ----
> arch/m68k/include/asm/mcfmbus.h | 77 ------------
> arch/m68k/include/asm/mcfne.h | 242 ------------------------------------
> arch/m68k/include/asm/sbus.h | 45 -------
> 6 files changed, 0 insertions(+), 787 deletions(-)
> delete mode 100644 arch/m68k/include/asm/MC68332.h
> delete mode 100644 arch/m68k/include/asm/apollodma.h
> delete mode 100644 arch/m68k/include/asm/mac_mouse.h
> delete mode 100644 arch/m68k/include/asm/mcfmbus.h
> delete mode 100644 arch/m68k/include/asm/mcfne.h
> delete mode 100644 arch/m68k/include/asm/sbus.h
>
--
------------------------------------------------------------------------
Greg Ungerer -- Principal Engineer EMAIL: gerg@snapgear.com
SnapGear Group, McAfee PHONE: +61 7 3435 2888
8 Gardner Close FAX: +61 7 3217 5323
Milton, QLD, 4064, Australia WEB: http://www.SnapGear.com
next prev parent reply other threads:[~2012-06-08 6:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-07 8:57 [PATCH] m68k: remove six unused headers Paul Bolle
2012-06-08 6:26 ` Greg Ungerer [this message]
2012-06-10 8:40 ` Geert Uytterhoeven
2012-06-12 6:06 ` Greg Ungerer
2012-06-12 7:24 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FD19B29.4050904@snapgear.com \
--to=gerg@snapgear.com \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=pebolle@tiscali.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox