From: Nitin Gupta <ngupta@vflare.org>
To: Sam Hansen <solid.se7en@gmail.com>
Cc: Sam Hansen <sam@meebo-inc.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jerome Marchand <jmarchan@redhat.com>,
Seth Jennings <sjenning@linux.vnet.ibm.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] staging: zram: conventions, __aligned() attribute
Date: Fri, 08 Jun 2012 00:37:10 -0700 [thread overview]
Message-ID: <4FD1ABA6.6030103@vflare.org> (raw)
In-Reply-To: <1339100404-18773-3-git-send-email-solid.se7en@gmail.com>
On 06/07/2012 01:20 PM, Sam Hansen wrote:
> Using the __aligned() attribute in favor of __attribute__((aligned(size)))
>
> Signed-off-by: Sam Hansen <solid.se7en@gmail.com>
> ---
> drivers/staging/zram/zram_drv.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/zram/zram_drv.h b/drivers/staging/zram/zram_drv.h
> index fbe8ac9..cda89ec 100644
> --- a/drivers/staging/zram/zram_drv.h
> +++ b/drivers/staging/zram/zram_drv.h
> @@ -85,7 +85,7 @@ struct table {
> u16 size; /* object size (excluding header) */
> u8 count; /* object ref count (not yet used) */
> u8 flags;
> -} __attribute__((aligned(4)));
> +} __aligned(4);
>
> struct zram_stats {
> u64 compr_size; /* compressed size of pages stored */
I plan to get rid of this table soon (as part of zsmalloc compaction
work). So, we can skip any changes to this part of the code.
Thanks,
Nitin
next prev parent reply other threads:[~2012-06-08 7:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-07 20:20 [PATCH 0/3] Styleguide conformity Sam Hansen
2012-06-07 20:20 ` [PATCH 1/3] staging: zram: conventions pr_warning -> pr_warn() Sam Hansen
2012-06-08 7:34 ` Nitin Gupta
2012-06-07 20:20 ` [PATCH 2/3] staging: zram: conventions, __aligned() attribute Sam Hansen
2012-06-08 7:37 ` Nitin Gupta [this message]
2012-06-07 20:20 ` [PATCH 3/3] staging: zram: conventions, line splitting Sam Hansen
2012-06-07 20:28 ` Joe Perches
2012-06-07 20:30 ` sam hansen
2012-06-07 23:03 ` [PATCH V2 0/3] Styleguide conformity Sam Hansen
2012-06-07 23:03 ` [PATCH V2 1/3] staging: zram: conventions pr_warning -> pr_warn() Sam Hansen
2012-06-07 23:03 ` [PATCH V2 2/3] staging: zram: conventions, __aligned() attribute Sam Hansen
2012-06-07 23:03 ` [PATCH V2 3/3] staging: zram: conventions, line splitting Sam Hansen
2012-06-08 7:42 ` Nitin Gupta
2012-06-11 16:04 ` Greg Kroah-Hartman
2012-06-11 22:08 ` Sam Hansen
2012-06-11 22:26 ` Greg Kroah-Hartman
2012-06-11 22:29 ` Sam Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FD1ABA6.6030103@vflare.org \
--to=ngupta@vflare.org \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jmarchan@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@meebo-inc.com \
--cc=sjenning@linux.vnet.ibm.com \
--cc=solid.se7en@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox