* [PATCH v2] MFD: twl6040: Update Kconfig to avoid build breakage
@ 2012-06-08 8:54 Peter Ujfalusi
2012-06-08 16:57 ` Randy Dunlap
2012-06-29 16:30 ` Samuel Ortiz
0 siblings, 2 replies; 3+ messages in thread
From: Peter Ujfalusi @ 2012-06-08 8:54 UTC (permalink / raw)
To: Samuel Ortiz, Stephen Rothwell
Cc: linux-kernel, linux-next, t-kristo, Randy Dunlap, peter.ujfalusi
twl6040 needs CONFIG_IRQ_DOMAIN to compile, without this we have:
drivers/mfd/twl6040-irq.c: In function 'twl6040_irq_init':
drivers/mfd/twl6040-irq.c:164:2: error: implicit declaration of function 'irq_domain_add_legacy'
drivers/mfd/twl6040-irq.c:165:11: error: 'irq_domain_simple_ops' undeclared (first use in this function)
drivers/mfd/twl6040-irq.c:165:11: note: each undeclared identifier is reported only once for each function it appears in
Reported-by: Randy Dunlap <rdunlap@xenotime.net>
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
drivers/mfd/Kconfig | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index e129c82..92144ed 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -286,6 +286,7 @@ config TWL6040_CORE
depends on I2C=y && GENERIC_HARDIRQS
select MFD_CORE
select REGMAP_I2C
+ select IRQ_DOMAIN
default n
help
Say yes here if you want support for Texas Instruments TWL6040 audio
--
1.7.8.6
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] MFD: twl6040: Update Kconfig to avoid build breakage
2012-06-08 8:54 [PATCH v2] MFD: twl6040: Update Kconfig to avoid build breakage Peter Ujfalusi
@ 2012-06-08 16:57 ` Randy Dunlap
2012-06-29 16:30 ` Samuel Ortiz
1 sibling, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2012-06-08 16:57 UTC (permalink / raw)
To: Peter Ujfalusi
Cc: Samuel Ortiz, Stephen Rothwell, linux-kernel, linux-next,
t-kristo
On 06/08/2012 01:54 AM, Peter Ujfalusi wrote:
> twl6040 needs CONFIG_IRQ_DOMAIN to compile, without this we have:
> drivers/mfd/twl6040-irq.c: In function 'twl6040_irq_init':
> drivers/mfd/twl6040-irq.c:164:2: error: implicit declaration of function 'irq_domain_add_legacy'
> drivers/mfd/twl6040-irq.c:165:11: error: 'irq_domain_simple_ops' undeclared (first use in this function)
> drivers/mfd/twl6040-irq.c:165:11: note: each undeclared identifier is reported only once for each function it appears in
>
> Reported-by: Randy Dunlap <rdunlap@xenotime.net>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Acked-by: Randy Dunlap <rdunlap@xenotime.net>
Thanks.
> ---
> drivers/mfd/Kconfig | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index e129c82..92144ed 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -286,6 +286,7 @@ config TWL6040_CORE
> depends on I2C=y && GENERIC_HARDIRQS
> select MFD_CORE
> select REGMAP_I2C
> + select IRQ_DOMAIN
> default n
> help
> Say yes here if you want support for Texas Instruments TWL6040 audio
--
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] MFD: twl6040: Update Kconfig to avoid build breakage
2012-06-08 8:54 [PATCH v2] MFD: twl6040: Update Kconfig to avoid build breakage Peter Ujfalusi
2012-06-08 16:57 ` Randy Dunlap
@ 2012-06-29 16:30 ` Samuel Ortiz
1 sibling, 0 replies; 3+ messages in thread
From: Samuel Ortiz @ 2012-06-29 16:30 UTC (permalink / raw)
To: Peter Ujfalusi
Cc: Stephen Rothwell, linux-kernel, linux-next, t-kristo,
Randy Dunlap
Hi Peter,
On Fri, Jun 08, 2012 at 11:54:21AM +0300, Peter Ujfalusi wrote:
> twl6040 needs CONFIG_IRQ_DOMAIN to compile, without this we have:
> drivers/mfd/twl6040-irq.c: In function 'twl6040_irq_init':
> drivers/mfd/twl6040-irq.c:164:2: error: implicit declaration of function 'irq_domain_add_legacy'
> drivers/mfd/twl6040-irq.c:165:11: error: 'irq_domain_simple_ops' undeclared (first use in this function)
> drivers/mfd/twl6040-irq.c:165:11: note: each undeclared identifier is reported only once for each function it appears in
>
> Reported-by: Randy Dunlap <rdunlap@xenotime.net>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
> drivers/mfd/Kconfig | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
Patch applied to my for-linus branch, sorry for the delay.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-06-29 16:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-08 8:54 [PATCH v2] MFD: twl6040: Update Kconfig to avoid build breakage Peter Ujfalusi
2012-06-08 16:57 ` Randy Dunlap
2012-06-29 16:30 ` Samuel Ortiz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox