From: "H. Peter Anvin" <hpa@zytor.com>
To: Hans Rosenfeld <hans.rosenfeld@amd.com>
Cc: tglx@linutronix.de, mingo@elte.hu, linux-kernel@vger.kernel.org,
x86@kernel.org
Subject: Re: [PATCH 5/5] x86, cacheinfo, amd: fix reported cache parameters for family 0x10
Date: Fri, 08 Jun 2012 11:16:19 -0700 [thread overview]
Message-ID: <4FD24173.4060807@zytor.com> (raw)
In-Reply-To: <1339087559-32604-5-git-send-email-hans.rosenfeld@amd.com>
On 06/07/2012 09:45 AM, Hans Rosenfeld wrote:
> + unsigned int reg;
> + pci_read_config_dword(nb->misc, 0x1d4, ®);
> + if ((reg & 0x3))
> + assoc -= 8;
> + }
/home/hpa/kernel/tip.x86-cpu/arch/x86/kernel/cpu/amd_cacheinfo.c: In
function ‘amd_cpuid4’:
/home/hpa/kernel/tip.x86-cpu/arch/x86/kernel/cpu/amd_cacheinfo.c:127:13:
warning: ‘reg’ may be used uninitialized in this function [-Wuninitialized]
Please don't send patchsets which introduce new warnings.
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
next prev parent reply other threads:[~2012-06-08 18:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-07 16:45 [PATCH 1/5] x86, cacheinfo, amd: use cpuid topology extensions to enumerate caches Hans Rosenfeld
2012-06-07 16:45 ` [PATCH 2/5] x86, cacheinfo: it's not only cpuid 4 anymore Hans Rosenfeld
2012-06-07 16:45 ` [PATCH 3/5] x86, cacheinfo: split intel_cacheinfo.c Hans Rosenfeld
2012-06-07 16:45 ` [PATCH 4/5] x86, cacheinfo: use find_num_cache_leaves on AMD systems Hans Rosenfeld
2012-06-07 16:45 ` [PATCH 5/5] x86, cacheinfo, amd: fix reported cache parameters for family 0x10 Hans Rosenfeld
2012-06-08 18:16 ` H. Peter Anvin [this message]
2012-06-11 10:33 ` Hans Rosenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FD24173.4060807@zytor.com \
--to=hpa@zytor.com \
--cc=hans.rosenfeld@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox