From: Roland Stigge <stigge@antcom.de>
To: Arnd Bergmann <arnd@arndb.de>
Cc: arm@kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kevin.wells@nxp.com,
srinivas.bakki@nxp.com, aletes.xgr@gmail.com
Subject: Re: [PATCH 11/14] ARM: LPC32xx: DTS adjustment for using pl18x primecell
Date: Mon, 11 Jun 2012 16:28:38 +0200 [thread overview]
Message-ID: <4FD60096.7050603@antcom.de> (raw)
In-Reply-To: <201206111414.14264.arnd@arndb.de>
On 06/11/2012 04:14 PM, Arnd Bergmann wrote:
> On Monday 11 June 2012, Roland Stigge wrote:
>> sd@20098000 {
>> - compatible = "arm,pl180", "arm,primecell";
>> + compatible = "arm,pl18x", "arm,primecell";
>> reg = <0x20098000 0x1000>;
>> interrupts = <0x0f 0>, <0x0d 0>;
>> + status = "disable";
>> };
>>
>
> The proper way to write this is 'status = "disabled";', with a 'd' at
> the end.
Thanks for the note!
Funnily, I always did it this way. Looks like initially, I copied from
somewhere else (wrongly). Indeed, we have lots of "disable", see also:
omap3-beagle.dts
omap4-panda.dts
omap4-sdp.dts
tegra20.dtsi
tegra30.dtsi
Roland
next prev parent reply other threads:[~2012-06-11 14:28 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-11 11:02 [PATCH 0/14] ARM: LPC32xx specific updates for next Roland Stigge
2012-06-11 11:02 ` [PATCH 1/14] ARM: LPC32xx: Add NAND flash timing to PHY3250 board dts Roland Stigge
2012-06-11 22:19 ` Alexandre Pereira da Silva
2012-06-11 11:02 ` [PATCH 2/14] ARM: LPC32xx: Clock initialization for NAND controllers Roland Stigge
2012-06-11 11:02 ` [PATCH 3/14] ARM: LPC32xx: Remove SLC controller initialization from platform init Roland Stigge
2012-06-11 22:19 ` Alexandre Pereira da Silva
2012-06-11 11:02 ` [PATCH 4/14] ARM: LPC32xx: Add DMA configuration to platform data Roland Stigge
2012-06-11 11:10 ` Russell King - ARM Linux
2012-06-14 17:07 ` Roland Stigge
2012-06-11 11:02 ` [PATCH 5/14] ARM: LPC32xx: Adjust dtsi file for MLC controller configuration Roland Stigge
2012-06-11 22:20 ` Alexandre Pereira da Silva
2012-06-11 11:02 ` [PATCH 6/14] ARM: LPC32xx: Add dts for EA3250 reference board Roland Stigge
2012-06-11 22:20 ` Alexandre Pereira da Silva
2012-06-11 11:02 ` [PATCH 7/14] ARM: LPC32xx: DTS adjustment for key matrix controller Roland Stigge
2012-06-11 22:21 ` Alexandre Pereira da Silva
2012-06-11 11:02 ` [PATCH 8/14] ARM: LPC32xx: Clock " Roland Stigge
2012-06-11 14:16 ` Arnd Bergmann
2012-06-11 14:34 ` Roland Stigge
2012-06-11 14:58 ` Arnd Bergmann
2012-06-11 11:02 ` [PATCH 9/14] ARM: LPC32xx: Defconfig update Roland Stigge
2012-06-11 22:22 ` Alexandre Pereira da Silva
2012-06-11 11:02 ` [PATCH 10/14] ARM: LPC32xx: Add MMC controller support Roland Stigge
2012-06-11 22:23 ` Alexandre Pereira da Silva
2012-06-11 11:02 ` [PATCH 11/14] ARM: LPC32xx: DTS adjustment for using pl18x primecell Roland Stigge
2012-06-11 14:14 ` Arnd Bergmann
2012-06-11 14:28 ` Roland Stigge [this message]
2012-06-11 14:57 ` Arnd Bergmann
2012-06-11 11:02 ` [PATCH 12/14] ARM: LPC32xx: DT conversion of Standard UARTs Roland Stigge
2012-06-11 22:23 ` Alexandre Pereira da Silva
2012-06-11 11:02 ` [PATCH 13/14] ARM: LPC32xx: High Speed UART configuration via DT Roland Stigge
2012-06-11 22:25 ` Alexandre Pereira da Silva
2012-06-11 11:02 ` [PATCH 14/14] ARM: LPC32xx: Remove mach specific ARCH_NR_GPIOS, use default Roland Stigge
2012-06-11 22:24 ` Alexandre Pereira da Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FD60096.7050603@antcom.de \
--to=stigge@antcom.de \
--cc=aletes.xgr@gmail.com \
--cc=arm@kernel.org \
--cc=arnd@arndb.de \
--cc=kevin.wells@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=srinivas.bakki@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox