From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: Borislav Petkov <borislav.petkov@amd.com>
Cc: edac-devel <linux-edac@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] edac: rewrite the sysfs code to use struct device
Date: Mon, 11 Jun 2012 13:23:09 -0300 [thread overview]
Message-ID: <4FD61B6D.7040405@redhat.com> (raw)
In-Reply-To: <20120608125219.GA31359@aftab.osrc.amd.com>
Em 08-06-2012 09:52, Borislav Petkov escreveu:
> From c0d119126e1b6daf9fe71614971233ffc90a873a Mon Sep 17 00:00:00 2001
> From: Mauro Carvalho Chehab <mchehab@redhat.com>
> Date: Mon, 16 Apr 2012 16:41:11 -0300
> Subject: [PATCH] edac: rewrite the sysfs code to use struct device
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
>
<skip/>
[will check the UTF-8 issue later]
>
> Hrrm,
>
> this patch doesn't build here, ontop of 3.5-rc1, config attached.
>
> In file included from arch/x86/kernel/nmi.c:23:0:
> include/linux/edac.h:452:16: error: field ‘dev’ has incomplete type
> include/linux/edac.h:488:16: error: field ‘dev’ has incomplete type
> include/linux/edac.h:498:16: error: field ‘dev’ has incomplete type
> include/linux/edac.h:553:18: error: field ‘dev’ has incomplete type
> include/linux/edac.h:554:20: error: field ‘bus’ has incomplete type
> make[2]: *** [arch/x86/kernel/nmi.o] Error 1
> make[1]: *** [arch/x86/kernel] Error 2
> make[1]: *** Waiting for unfinished jobs....
> In file included from drivers/edac/edac_stub.c:16:0:
> include/linux/edac.h:452:16: error: field ‘dev’ has incomplete type
> include/linux/edac.h:488:16: error: field ‘dev’ has incomplete type
> include/linux/edac.h:498:16: error: field ‘dev’ has incomplete type
> include/linux/edac.h:553:18: error: field ‘dev’ has incomplete type
> include/linux/edac.h:554:20: error: field ‘bus’ has incomplete type
> make[2]: *** [drivers/edac/edac_stub.o] Error 1
> make[1]: *** [drivers/edac] Error 2
> make[1]: *** Waiting for unfinished jobs....
> make: *** [arch/x86] Error 2
> make: *** Waiting for unfinished jobs....
>
I'll fold the enclosed patch. It should fix this issue.
diff --git a/include/linux/edac.h b/include/linux/edac.h
index aeaafd0..a2b0b6f 100644
--- a/include/linux/edac.h
+++ b/include/linux/edac.h
@@ -13,6 +13,7 @@
#define _LINUX_EDAC_H_
#include <linux/atomic.h>
+#include <linux/device.h>
#include <linux/kobject.h>
#include <linux/completion.h>
#include <linux/workqueue.h>
next prev parent reply other threads:[~2012-06-11 16:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-08 12:52 [PATCH] edac: rewrite the sysfs code to use struct device Borislav Petkov
2012-06-11 16:23 ` Mauro Carvalho Chehab [this message]
2012-06-11 16:37 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FD61B6D.7040405@redhat.com \
--to=mchehab@redhat.com \
--cc=borislav.petkov@amd.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox