From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Namjae Jeon <linkinjeon@gmail.com>
Cc: James.Bottomley@hansenpartnership.com,
gregkh@linuxfoundation.org, mdharm-usb@one-eyed-alien.net,
stern@rowland.harvard.edu, bvanassche@acm.org,
linux-usb@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org,
Namjae Jeon <namjae.jeon@samsung.com>,
Pankaj Kumar <pankaj.km@samsung.com>,
Amit Sahrawat <a.sahrawat@samsung.com>
Subject: Re: [PATCH v3 3/3] usb: storage: update usb devices for write cache quirk in quirk list.
Date: Mon, 11 Jun 2012 21:09:39 +0400 [thread overview]
Message-ID: <4FD62653.7060206@mvista.com> (raw)
In-Reply-To: <CAKYAXd9Evpo6jn+_+bnyNeaX9vmPicVp5Xm-12tp_U4=wb6Pgw@mail.gmail.com>
Hello.
On 10-06-2012 4:45, Namjae Jeon wrote:
>>> Update information of Seagate Portable HDD and WD My Passport HDD in
>>> quirk list.
>>> Signed-off-by: Namjae Jeon<namjae.jeon@samsung.com>
>>> Signed-off-by: Pankaj Kumar<pankaj.km@samsung.com>
>>> Signed-off-by: Amit Sahrawat<a.sahrawat@samsung.com>
>>> ---
>>> drivers/usb/storage/unusual_devs.h | 24 ++++++++++++++++++++++++
>>> 1 file changed, 24 insertions(+)
>>> diff --git a/drivers/usb/storage/unusual_devs.h
>>> b/drivers/usb/storage/unusual_devs.h
>>> index 1719886..64f0369 100644
>>> --- a/drivers/usb/storage/unusual_devs.h
>>> +++ b/drivers/usb/storage/unusual_devs.h
>>> @@ -1267,6 +1267,18 @@ UNUSUAL_DEV( 0x0af0, 0xd357, 0x0000, 0x0000,
>>> USB_SC_DEVICE, USB_PR_DEVICE, NULL,
>>> 0 ),
>>>
>>> +/* Reported by Namjae Jeon<namjae.jeon@samsung.com>
>>> + * Even though write cache is enabled by default,
>>> + * SCSI driver assume that cache is not enabled
>>> + * which in turn might lead loss of data
>> ^ to the
>>> + * since data still will be in cache.
>>> + * So this entry is needed for assuming that cache is enabled.
>>> + */
>>> +UNUSUAL_DEV(0x0bc2, 0x2300, 0x0000, 0x9999,
>>> + "Seagate",
>>> + "Portable HDD",
>>> + USB_SC_DEVICE, USB_PR_DEVICE, NULL, US_FL_WRITE_CACHE),
>>> +
>>> /* Reported by Ben Efros<ben@pc-doctor.com> */
>>> UNUSUAL_DEV( 0x0bc2, 0x3010, 0x0000, 0x0000,
>>> "Seagate",
>>> @@ -1468,6 +1480,18 @@ UNUSUAL_DEV( 0x1058, 0x0704, 0x0000, 0x9999,
>>> USB_SC_DEVICE, USB_PR_DEVICE, NULL,
>>> US_FL_SANE_SENSE),
>>>
>>> +/* Reported by Namjae Jeon<namjae.jeon@samsung.com>
>>> + * Even though write cache is enabled by default,
>>> + * SCSI driver assume that cache is not enabled
>>> + * which in turn might lead loss of data
>> ^ to the
> to the ? Sorry, I don't understand what you want to change.
> like this ? "Even though write cache is enabled by default, SCSI
> driver assume that cache is not enabled and it in turn might lead the
> loss of data. "
Lead to the loss of data.
WBR, Sergei
next prev parent reply other threads:[~2012-06-11 17:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-09 17:41 [PATCH v3 3/3] usb: storage: update usb devices for write cache quirk in quirk list Namjae Jeon
2012-06-09 18:44 ` Sergei Shtylyov
2012-06-10 0:45 ` Namjae Jeon
2012-06-11 17:09 ` Sergei Shtylyov [this message]
2012-06-11 22:47 ` Namjae Jeon
-- strict thread matches above, loose matches on Subject: below --
2012-06-10 1:30 Namjae Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FD62653.7060206@mvista.com \
--to=sshtylyov@mvista.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=a.sahrawat@samsung.com \
--cc=bvanassche@acm.org \
--cc=gregkh@linuxfoundation.org \
--cc=linkinjeon@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mdharm-usb@one-eyed-alien.net \
--cc=namjae.jeon@samsung.com \
--cc=pankaj.km@samsung.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox