From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752335Ab2FKRML (ORCPT <rfc822;w@1wt.eu>);
	Mon, 11 Jun 2012 13:12:11 -0400
Received: from mail-lpp01m010-f46.google.com ([209.85.215.46]:48771 "EHLO
	mail-lpp01m010-f46.google.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1751422Ab2FKRMJ (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 11 Jun 2012 13:12:09 -0400
Message-ID: <4FD626C1.1010507@mvista.com>
Date: Mon, 11 Jun 2012 21:11:29 +0400
From: Sergei Shtylyov <sshtylyov@mvista.com>
User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:12.0) Gecko/20120428 Thunderbird/12.0.1
MIME-Version: 1.0
To: Namjae Jeon <linkinjeon@gmail.com>
CC: James.Bottomley@hansenpartnership.com, gregkh@linuxfoundation.org,
        mdharm-usb@one-eyed-alien.net, stern@rowland.harvard.edu,
        bvanassche@acm.org, linux-usb@vger.kernel.org,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        Namjae Jeon <namjae.jeon@samsung.com>,
        Pankaj Kumar <pankaj.km@samsung.com>,
        Amit Sahrawat <a.sahrawat@samsung.com>
Subject: Re: [PATCH v3 2/4] usb: storage: add support for write cache quirk
 on usb hdd
References: <1339263660-4039-1-git-send-email-linkinjeon@gmail.com> <4FD39904.2010808@mvista.com> <CAKYAXd9EUqxUBw1YWr2FnBrg1K=uGWiaEFYtSgu-J3nZ9sLvuQ@mail.gmail.com>
In-Reply-To: <CAKYAXd9EUqxUBw1YWr2FnBrg1K=uGWiaEFYtSgu-J3nZ9sLvuQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello.

On 10-06-2012 4:30, Namjae Jeon wrote:

>>> Add support for write cache quirk on usb hdd. scsi driver will be set to
>>> wce
>>> by detecting write cache quirk in quirk list when plugging usb hdd.

>>> Signed-off-by: Namjae Jeon<namjae.jeon@samsung.com>
>>> Signed-off-by: Pankaj Kumar<pankaj.km@samsung.com>
>>> Signed-off-by: Amit Sahrawat<a.sahrawat@samsung.com>
>>> ---
>>>    drivers/usb/storage/scsiglue.c |    5 +++++
>>>    drivers/usb/storage/usb.c      |    5 ++++-
>>>    include/linux/usb_usual.h      |    4 +++-
>>>    3 files changed, 12 insertions(+), 2 deletions(-)

>>> diff --git a/drivers/usb/storage/scsiglue.c
>>> b/drivers/usb/storage/scsiglue.c
>>> index a324a5d..fe42547 100644
>>> --- a/drivers/usb/storage/scsiglue.c
>>> +++ b/drivers/usb/storage/scsiglue.c
>> [...]
>>> @@ -529,6 +529,9 @@ static void adjust_quirks(struct us_data *us)
>>>    		case 'o':
>>>    			f |= US_FL_CAPACITY_OK;
>>>    			break;
>>> +		case 'p':
>>> +			f |= US_FL_WRITE_CACHE;
>>> +			break;
>>>    		case 'r':
>>>    			f |= US_FL_IGNORE_RESIDUE;
>>>    			break;
>>
>>      You probably should unite this chunk with the documentation update
>> patch.

> Hi Sergei.
> I tried to post documentation update patch(4/4) for this chunk.
> Do I misunderstand ?

    I mean that the documenation should be updated in the same patch where you 
add the new value.

WBR, Sergei